develooper Front page | perl.perl5.porters | Postings from July 2003

Re: [PATCH] test clean-up for VMS

Thread Previous | Thread Next
From:
H.Merijn Brand
Date:
July 21, 2003 08:42
Subject:
Re: [PATCH] test clean-up for VMS
Message ID:
20030721174107.EB71.H.M.BRAND@hccnet.nl
On Sun 20 Jul 2003 17:43, "Craig A. Berry" <craigberry@mac.com> wrote:
> Michael G Schwern wrote:
> >>-  unlink @files;
> >>+  for $f (@files) { close $f; 1 while unlink $f; }
> >> }
> > 
> > 
> > Any reason this couldn't be written:  1 while unlink @files; ?
> 
> I was trying to make explicit the fact that multiple versions of each
> file may need to be deleted. On reflection my formulation doesn't really
> communicate anything that the simpler "1 while unlink" is missing.
> 
> > Does it make any sense to close() a filename?
> 
> Well, it doesn't to Perl, and I don't know why it did to me when I wrote
> it. Obviously that has to go.
> 
> Another version of the patch is attached with these issues corrected.

Thanks, the other version applied as change #20175

-- 
H.Merijn Brand        Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using perl-5.6.1, 5.8.0 & 633 on HP-UX 10.20 & 11.00, AIX 4.2, AIX 4.3,
  WinNT 4, Win2K pro & WinCE 2.11.  Smoking perl CORE: smokers@perl.org
http://archives.develooper.com/daily-build@perl.org/   perl-qa@perl.org
send smoke reports to: smokers-reports@perl.org, QA: http://qa.perl.org



Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About