develooper Front page | perl.perl5.porters | Postings from July 2003

Re: [PATCH] test clean-up for VMS

Thread Previous
From:
H.Merijn Brand
Date:
July 20, 2003 02:31
Subject:
Re: [PATCH] test clean-up for VMS
Message ID:
20030720112831.ED5F.H.M.BRAND@hccnet.nl
On Sun 20 Jul 2003 08:31, Michael G Schwern <schwern@pobox.com> wrote:
> > --- lib/FileCache/t/01open.t;-0	Sun Jun 22 15:56:24 2003
> > +++ lib/FileCache/t/01open.t	Sat Jul 19 18:37:48 2003
> > @@ -10,7 +10,7 @@
> >      END;
> >  }
> >  END{
> > -  unlink @files;
> > +  for $f (@files) { close $f; 1 while unlink $f; }
> >  }
> 
> Any reason this couldn't be written:  1 while unlink @files; ?

I was to write the same, with as extra note: make tests strict/warning safe
whereever possible, so

for my $f (@files) ...
    ^^

> Does it make any sense to close() a filename?

-- 
H.Merijn Brand        Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using perl-5.6.1, 5.8.0 & 633 on HP-UX 10.20 & 11.00, AIX 4.2, AIX 4.3,
  WinNT 4, Win2K pro & WinCE 2.11.  Smoking perl CORE: smokers@perl.org
http://archives.develooper.com/daily-build@perl.org/   perl-qa@perl.org
send smoke reports to: smokers-reports@perl.org, QA: http://qa.perl.org


Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About