[perl #22354] remove $*

Ton Hospel wrote:
> Making $* lexically scoped probably already breaks pograms that still
> depend on it. So kill it, I'd say. It has been documented as deprecated
> for a long time, and gives a deprecation warning in actual code.
> Now it's also clear it causes bugs in real code.

I've verified that removing $* solves this bug (and breaks nothing
else in the core.) The most important point of the patch is pasted
below.

But I've a question :
As of 5.8.x, $* gives a deprecation warning :

  $ perl -we '$*=1'
  Use of $* is deprecated at -e line 1.

When removing a deprecated feature, should the deprecation
warning be removed as well ?


--- pp_hot.c    (revision 1474)
+++ pp_hot.c    (working copy)
@@ -1234,7 +1234,7 @@
     if (SvSCREAM(TARG))
        r_flags |= REXEC_SCREAM;
 
-    if (pm->op_pmflags & (PMf_MULTILINE|PMf_SINGLELINE)) {
+    if ((pm->op_pmflags & PMf_MULTILINE) != PL_multiline) {
        SAVEINT(PL_multiline);
        PL_multiline = pm->op_pmflags & PMf_MULTILINE;
     }
@@ -1979,7 +1979,7 @@
               ? REXEC_COPY_STR : 0;
     if (SvSCREAM(TARG))
        r_flags |= REXEC_SCREAM;
-    if (pm->op_pmflags & (PMf_MULTILINE|PMf_SINGLELINE)) {
+    if ((pm->op_pmflags & PMf_MULTILINE) != PL_multiline) {
        SAVEINT(PL_multiline);
        PL_multiline = pm->op_pmflags & PMf_MULTILINE;
     }

• [perl #22354] s/// flags influence regex use in the replacement body by perlbug-followup
• Re: [perl #22354] s/// flags influence regex use in the replacement body by Rafael Garcia-Suarez
• Re: [perl #22354] s/// flags influence regex use in the replacement body by perl5-porters
• [perl #22354] remove $* by Rafael Garcia-Suarez
• Re: [perl #22354] remove $* by A. Pagaltzis
• Re: [perl #22354] s/// flags influence regex use in the replacement body by Rafael Garcia-Suarez
• Re: [perl #22354] remove $* by Richard Soderberg
• Re: [perl #22354] remove $* by david nicol
• Re: [perl #22354] remove $* by Abigail