develooper Front page | perl.perl5.porters | Postings from May 2003

Re: [perl #22372] [PATCH] sv_chop() broken

Thread Previous | Thread Next
From:
Rafael Garcia-Suarez
Date:
May 31, 2003 06:03
Subject:
Re: [perl #22372] [PATCH] sv_chop() broken
Message ID:
20030531150338.15143bd6.rgarciasuarez@free.fr
Enache Adrian wrote:
> On Sat, May 31, 2003 at 11:10:56AM +0200, Rafael Garcia-Suarez wrote:
> > Enache Adrian wrote:
> > > +{
> > > +    my $el;
> > > +    format STDOUT =
> > > +ok ^<<<<<<<<<<<<<<~~ # sv_chop() naze
> > > +$el
> > > +.
> > > +    my %hash = (12 => 3);
> > > +    for $el (keys %hash) {
> > > +	write;
> > > +    }
> > > +}
> > This outputs nothing for me.
> 
> That's curious, because blead ~ 19600 just worked.
> Changing 'my $el' to 'our $el' makes it work again (blead@19641).

Qualifies as a bug. Maybe the jumbo closure patch (19367) is
responsible?
In the meantime, I've applied your updated patch.

> > Moreover you apparenly forgot to update the skip count a few lines
> > below :
> 
> Oops.
> Modified patch for t/op/write.t below.
> 
> --- /arc/bleadperl/t/op/write.t	2002-04-29 00:31:14.000000000 +0300
> +++ ./t/op/write.t	2003-05-31 14:10:11.000000000 +0300
> @@ -5,7 +5,7 @@ BEGIN {
>      @INC = '../lib';
>  }
>  
> -print "1..47\n";
> +print "1..48\n";
>  
>  my $CAT = ($^O eq 'MSWin32' || $^O eq 'NetWare' || $^O eq 'VMS') ? 'type'
>  	: ($^O eq 'MacOS') ? 'catenate'
> @@ -271,17 +271,29 @@ if (`$CAT Op_write.tmp` eq $right)
>  else
>      { print "not ok 11\n"; }
>  
> -# 12..47: scary format testing from Merijn H. Brand
> +{
> +    our $el;
> +    format STDOUT =
> +ok ^<<<<<<<<<<<<<<~~ # sv_chop() naze

"naze" really sounds like french slang, doesn't it ?

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About