develooper Front page | perl.perl5.porters | Postings from May 2003

[PATCH] RE: state of deparse?

From:
Robin Barker
Date:
May 23, 2003 09:42
Subject:
[PATCH] RE: state of deparse?
Message ID:
533D273D4014D411AB1D00062938C4D90404653E@hotel.npl.co.uk
I made a start at the test.deparse failures.

comp/hints.t fails because Deparse draws the blocks and BEGINs 
differently.

comp/our.t fails because Deparse does not understand C<our>.
I have made a rather brutal fix to B/Deparse.pm this causes
test.parse to pass comp/our.t and not fail any new tests.

Attached and appended.

Robin

-----Original Message-----
From: Jarkko Hietaniemi [mailto:jhi@iki.fi]
Sent: 22 May 2003 23:07
To: Abe Timmerman
Cc: perl5-porters@perl.org; smokers@perl.org
Subject: Re: state of deparse?


On Thu, May 22, 2003 at 11:43:44PM +0200, Abe Timmerman wrote:
> Op een zonnige lentedag (Thursday 22 May 2003 16:20), schreef Jarkko 
> Hietaniemi:
> 
> > Has anyone tried 'make test.deparse' lately?
> 
> I wasn't aware this target existed.
> 
> Would you all like me to try and incorporate this into Test::Smoke (as
an 
> option)?

No.  It won't work 100% for a long while.

> If so, should it be run once (no explicit
$ENV{PERLIO}/$ENV{PERL_UNICODE} 
> settings) or should it itterate over the same settings as 'make _test'
(under 
> -Duseperlio)?
> 
> 
> Good luck,
> 
> Abe
> -- 
> N-IS> Hmm - those block comments all look similar to me!
> They sure do look alike-- but I didn't feel that ambitious. Someone
else may.
>                                    -- Jarkko Hietaniemi on p5p @
2002-10-24
> 

--- ../perl@19525/ext/B/B/Deparse.pm	Mon Apr  7 06:02:53 2003
+++ ./ext/B/B/Deparse.pm
@@ -914,6 +914,10 @@
     if ($op->private & (OPpLVAL_INTRO|$our_intro)
 	and not $self->{'avoid_local'}{$$op}) {
 	my $our_local = ($op->private & OPpLVAL_INTRO) ? "local" :
"our";
+	if( $our_local eq 'our' ) {
+	    die "Unexpected our($text)\n" unless $text =~
/^\W(\w+::)*\w+\z/;
+	    $text =~ s/(\w+::)+//; 
+	}
         if (want_scalar($op)) {
 	    return "$our_local $text";
 	} else {
End of patch



-------------------------------------------------------------------
This e-mail and any attachments may contain confidential and/or
privileged material; it is for the intended addressee(s) only.
If you are not a named addressee, you must not use, retain or
disclose such information.

NPL Management Ltd cannot guarantee that the e-mail or any
attachments are free from viruses.

NPL Management Ltd. Registered in England and Wales. No: 2937881
Registered Office: Teddington, Middlesex, United Kingdom TW11 0LW.
-------------------------------------------------------------------


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About