develooper Front page | perl.perl5.porters | Postings from May 2003

[PATCH pod/perlmod.pod] Simpler $Revision$ based $VERSION. Plus, repentance!

Thread Next
From:
Michael G Schwern
Date:
May 3, 2003 15:30
Subject:
[PATCH pod/perlmod.pod] Simpler $Revision$ based $VERSION. Plus, repentance!
Message ID:
20030503223016.GE1234@windhund.schwern.org
Attached is a much, much, much simpler way to set your $VERSION from a
RCS/CVS $Revision$ for perlmod.

Also, I come to repent.  Way back when this was added I defended using
sprintf "%02d" saying [1]:

  When you put out your 98th minor revision to your module, let me know
  and we'll fix it. :)

  Seriously, having 100 minor revisions is extremely rare (hell, having
  100 revisions at ALL is rare)

$ cvs status lib/ExtUtils/MakeMaker.pm
===================================================================
File: MakeMaker.pm      Status: Locally Modified

   Working revision:    1.109   Tue Apr  8 04:16:11 2003

*embarassed cough*


--- pod/perlmod.pod	2003/05/03 22:17:32	1.1
+++ pod/perlmod.pod	2003/05/03 22:18:08
@@ -335,7 +335,7 @@
         # set the version for version checking
         $VERSION     = 1.00;
         # if using RCS/CVS, this may be preferred
-        $VERSION = do { my @r = (q$Revision: 1.1 $ =~ /\d+/g); sprintf "%d."."%02d" x $#r, @r }; # must be all one line, for MakeMaker
+        $VERSION = sprintf "%d.%03d", q$Revision: 1.1 $ =~ /(\d+)/g;
 
         @ISA         = qw(Exporter);
         @EXPORT      = qw(&func1 &func2 &func4);


[1] http://www.xray.mpe.mpg.de/mailing-lists/perl5-porters/2001-07/msg01509.html

-- 
The eye opening delightful morning taste of expired cheese bits in sour milk!

Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About