develooper Front page | perl.perl5.porters | Postings from April 2003

Re: [PATCH Encode 1.93] another spin on the enc_module.t merry-go-round

Thread Previous
Dan Kogai
April 24, 2003 20:36
Re: [PATCH Encode 1.93] another spin on the enc_module.t merry-go-round
Message ID:

On Friday, April 25, 2003, at 10:57  AM, Enache Adrian wrote:
> On Thu, Apr 24, 2003 at 08:09:48PM -0500, Craig A. Berry wrote:
>> I here attempt once again to do what change #19130 previously did, 
>> that
>> is, make sure that a file open for write gets closed before being
>> compared to another file. This is necessary for the test to pass on 
>> VMS.
>> I think the basic issue is that files are by default opened for
>> exclusive access on VMS; if you open a file that is already open (as 
>> the
>> file comparison in the test is doing), the second open will fail:
> That's what I wrote 4 days ago:
> :> >I suggested you to put
> :> >
> :> >close STDOUT unless $^O eq 'freebsd';

Okay. I think finally grokked.

* VMS needs STDOUT closed BEFORE comparison
* But FreeBSD+thread needs to leave it open
* and Win32 needs to close it before unlinking it.

And Craig's patch will do'em all.   Okay, I'll release pre-1.94 patch 
to mend that.

> And I'll be THANKFUL if you removed my surname from there - I hope
> to live longer than both Encode and FreeBSD's userland toy-threads :)

Okay, that too.  t/enc_module.t and AUTHORS.  Do you want just your 
surname (Enache or Adrian, which one?  I have to make sure) or the 
whole?  I checked perl-current/AUTHORS and your name did not show up 
there either.  Is that what you want?

Dan the Encode Maintainer Who also Wants to Outlive both

Thread Previous Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About