develooper Front page | perl.perl5.porters | Postings from April 2003

Re: [PATCH Encode 1.93] another spin on the enc_module.t merry-go-round

Thread Previous | Thread Next
From:
Enache Adrian
Date:
April 24, 2003 18:56
Subject:
Re: [PATCH Encode 1.93] another spin on the enc_module.t merry-go-round
Message ID:
20030425015701.GA2069@ratsnest.hole
On Thu, Apr 24, 2003 at 08:09:48PM -0500, Craig A. Berry wrote:
> I here attempt once again to do what change #19130 previously did, that
> is, make sure that a file open for write gets closed before being
> compared to another file. This is necessary for the test to pass on VMS.
> I think the basic issue is that files are by default opened for
> exclusive access on VMS; if you open a file that is already open (as the
> file comparison in the test is doing), the second open will fail:

That's what I wrote 4 days ago:

:> >I suggested you to put
:> >
:> >close STDOUT unless $^O eq 'freebsd';
:>
:> And I instead relocated "close STDOUT" AFTER the tests so this will not
:> do any good this time.
:
:Again, IIRC Craig Berry put it back because comparing open file
:won't work on VMS.

> +# I have tested and found "unless $^O eq 'freebsd'" is not
> +# necessary but I will leave it for the sake of Enache -- dankogai
> +# Please do not move this to a point after the comparison -- Craig Berry
> +close STDOUT unless $^O eq 'freebsd';

And I'll be THANKFUL if you removed my surname from there - I hope
to live longer than both Encode and FreeBSD's userland toy-threads :)

Regards
Adi

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About