develooper Front page | perl.perl5.porters | Postings from April 2003

Encode-1.92 was not marged right [Was: Re: FreeBSD thread vs. encoding.pm]

Thread Previous | Thread Next
From:
Dan Kogai
Date:
April 22, 2003 02:54
Subject:
Encode-1.92 was not marged right [Was: Re: FreeBSD thread vs. encoding.pm]
Message ID:
5A85C336-74A8-11D7-B05A-000393AE4244@dan.co.jp
On Tuesday, April 22, 2003, at 06:10  AM, Enache Adrian wrote:
> ratsnest# perl -pe 's/close STDOUT/$& unless \$^O eq q{freebsd}/' -i  
> ../ext/Encode/t/enc_module.t
> ratsnest# perl harness ../ext/Encode/t/enc_module.t                     
>          ../ext/Encode/t/enc_module....Parameter to use lib must be  
> directory, not file at ../ext/Encode/t/enc_module.t line 22
> ../ext/Encode/t/enc_module....ok
> All tests successful.
> Files=1, Tests=3,  0 wallclock secs ( 0.62 cusr +  0.04 csys =  0.66  
> CPU)

Mistery solved.  This gimmick is not necessary.  It has been solved in  
Encode-1.92 already but  Encode-1.92 was not merged as a whole!   
Encode-1.92 at CPAN works perfectly.   See this.

> > ../perl harness ../ext/Encode/t/enc_module.t                          
>                                             
> /home/dankogai/work/perl-current/ext/Encode/t/enc_module....NOK 1#      
> Failed test  
> (/home/dankogai/work/perl-current/ext/Encode/t/enc_module.t at line > 44)
> #          got: '1'
> #     expected: '0'
> # Looks like you planned 3 tests but only ran 1.
> /home/dankogai/work/perl-current/ext/Encode/t/enc_module....dubious
>         Test returned status 3 (wstat 768, 0x300)
> DIED. FAILED tests 1-3
>         Failed 3/3 tests, 0.00% okay
> Failed Test                       Stat Wstat Total Fail  Failed  List  
> of Failed
> ----------------------------------------------------------------------- 
> --------
> /home/dankogai/work/perl-current/    3   768     3    5 166.67%  1-3
> Failed 1/1 test scripts, 0.00% okay. 3/3 subtests failed, 0.00% okay.
> > ../perl harness ../ext/Encode-1.92/t/enc_module.t
> /home/dankogai/work/perl-current/ext/Encode-1.92/t/enc_module....ok
> All tests successful.
> Files=1, Tests=3,  0 wallclock secs ( 0.27 cusr +  0.02 csys =  0.29  
> CPU)

And this.

> > diff -u ext/Encode/Encode.pm ext/Encode-1.92/
> >

> diff -ruN ext/Encode ext/Encode-1.92|grep enc_module.tdiff -ruN  
> ext/Encode/t/enc_module.t ext/Encode-1.92/t/enc_module.t
> --- ext/Encode/t/enc_module.t   Wed Apr  2 14:55:40 2003
> +++ ext/Encode-1.92/t/enc_module.t      Mon Mar 31 12:47:19 2003

And this.

> > diff -u ext/Encode/t/enc_module.t  ext/Encode-1.92/t/
> --- ext/Encode/t/enc_module.t   Wed Apr  2 14:55:40 2003
> +++ ext/Encode-1.92/t/enc_module.t      Mon Mar 31 12:47:19 2003
> @@ -38,7 +38,6 @@
>  print $obj->str, "\n";
>  $obj->set("�ƥ���ʸ����");
>  print $obj->str, "\n";
> -close STDOUT;
>
>  my $cmp = compare_text($file0, $file1);
>  is($cmp, 0, "encoding vs. STDOUT");
> @@ -52,6 +51,7 @@
>      is ($cmp[$i++], $_, "encoding vs. STDIN - $i");
>  }
>
> +close STDOUT;
>  unlink $file1 unless $cmp;
>  __END__

Here is the conclusion.

* "close STDOUT" after the test is just enough to make FreeBSD happy
* But this patch, applied in Encode 1.92, was NOT MARGED RIGHT

Pumpkins, please (re)marge Encode 1.92.  Maybe it is because of *.ucm  
changes that prevented it from merging correctly.   I don't know what  
exactly has happened but Encode 1.92 was mismerged.

> > diff -ruN ext/Encode ext/Encode-1.92 | wc
>   232366  517653 11496952

Now back to Enache

> And I have a patch for you:
>
> --- /arc/bleadperl/ext/Encode/AUTHORS	Mon Mar 31 14:17:11 2003
> +++ ext/Encode/AUTHORS	Mon Apr 21 23:55:52 2003
> @@ -17,7 +17,6 @@
>  Craig A. Berry			<craigberry@mac.com>
>  Dan Kogai			<dankogai@dan.co.jp>
>  Elizabeth Mattijsen             <liz@dijkmat.nl>
> -Enache Adrian                   <enache@rdslink.ro>
>  Gerrit P. Haase			<gp@familiehaase.de>
>  Graham Barr                     <gbarr@pobox.com>
>  Gurusamy Sarathy		<gsar@activestate.com>

How come?  I consider anyone contributed a patch, however small it  
maybe, a (co)?author.  Do you want your name/mailto dropped for privacy  
reason?

Dan the Encode Maintainer


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About