develooper Front page | perl.perl5.porters | Postings from April 2003

Re: [PATCH] VMS %ENV fix (follow-up to 18852)

Thread Previous | Thread Next
From:
H.Merijn Brand
Date:
April 3, 2003 02:05
Subject:
Re: [PATCH] VMS %ENV fix (follow-up to 18852)
Message ID:
20030403120307.5949.H.M.BRAND@hccnet.nl
On Thu 03 Apr 2003 02:09, "Craig A. Berry" <craigberry@mac.com> wrote:
> In adding the ability to handle very long %ENV values in change #18852, I 
> failed to distinguish adequately between the uses of logical names to 
> support the %ENV hash and other internal uses of logical names (such as 
> manipulating file specs in VMSish ways).  This sometimes brings a 
> fixed-length buffer up against a value that is too long for it, causing 
> stack corruption and crashes.  The attached patch fixes that by adding a 
> flag to the logical name translation infrastructure in vms.c so that only 
> Perl_my_getenv and Perl_my_getenv_len will attempt to take advantage of the 
> longer values.  The internal function my_trnlnm may once again be safely 
> used as it always has for logical name translations not related to the 
> support of %ENV.
> 
> This should be applied to both 5.8.1 and bleadperl.

Applied to blead as change #19143

Please check (still the thread offset?)

l1:/pro/3gl/CPAN/perl-current 109 > npatch -p0 <../xx
patching file vms/vmsish.h
patching file vms/vms.c
Hunk #1 succeeded at 262 (offset -22 lines).
Hunk #2 succeeded at 290 (offset -22 lines).
Hunk #3 succeeded at 340 (offset -22 lines).
Hunk #4 succeeded at 369 (offset -22 lines).
Hunk #5 succeeded at 423 (offset -22 lines).
Hunk #6 succeeded at 455 (offset -22 lines).
l1:/pro/3gl/CPAN/perl-current 110 >

-- 
H.Merijn Brand        Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using perl-5.6.1, 5.8.0 & 633 on HP-UX 10.20 & 11.00, AIX 4.2, AIX 4.3,
  WinNT 4, Win2K pro & WinCE 2.11.  Smoking perl CORE: smokers@perl.org
http://archives.develooper.com/daily-build@perl.org/   perl-qa@perl.org
send smoke reports to: smokers-reports@perl.org, QA: http://qa.perl.org



Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About