develooper Front page | perl.perl5.porters | Postings from March 2003

Re: [PATCH 5.8.1 @19053] Time::HiRes

Thread Previous | Thread Next
From:
Jarkko Hietaniemi
Date:
March 31, 2003 23:13
Subject:
Re: [PATCH 5.8.1 @19053] Time::HiRes
Message ID:
20030401071251.GK9584@vipunen.hut.fi
> The test would emit a warning about a non-initialized variable.  (in a
> maze of branches my system managed to find one where 'xdefine' file is
> not written.)

Thanks, applied (to maint-5.8 as change #19109, will get eventually to
blead, too).

> I did not try to fix another goof (common for Time::HiRes and Encode):
> they test for PERL_CORE using some hideous code.  *At least* the check for miniperl in the test should be //i.  But anyway:
> 
>  a) I could find no place which would *read* $ENV{PERL_CORE};

Errr, umm, there are a few places at least in the HiRes Makefile.PL.

>  b) The proper way to test for PERL_CORE is test @ARGV for PERL_CORE=1.

It is?  Did you try it?  Maybe I goofed up something but I couldn't
get it to work quite right for the two scenarios we need to handle:
the point of the check is that we need to detect when we are being
built as part of the Perl core distribution, and when we are being
built under some already installed Perl (when the extensions Encode
and Time::HiRes are being installed from CPAN).  The current 'hack'
seems to be working, so...

-- 
Jarkko Hietaniemi <jhi@iki.fi> http://www.iki.fi/jhi/ "There is this special
biologist word we use for 'stable'.  It is 'dead'." -- Jack Cohen

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About