develooper Front page | perl.perl5.porters | Postings from March 2003

Re: [PATCH] Re: [perl #21614] 5.8.0 Unbalanced string table refcount

Thread Previous | Thread Next
From:
Rafael Garcia-Suarez
Date:
March 26, 2003 14:27
Subject:
Re: [PATCH] Re: [perl #21614] 5.8.0 Unbalanced string table refcount
Message ID:
20030326233005.14fd8b2e.rgarciasuarez@free.fr
Nicholas Clark wrote:
> 
> I think that the appended works. The test fails on 5.8.0 and unpatched blead.
> It passes on blead with and without COW. It doubt that the sv.c patch will
> apply to maint because the code's been moved around quite a bit.

Anyway, thanks, applied as #19069 to bleadperl.

> I'm not convinced that it's the cleanest logic yet. I think that it would
> actually be better to move the sv_release_COW() call from
> sv_force_normal_flags into sv_grow. (Which is actually back close to 5.8.0)
> This way for this case sv_grow gets to call malloc once with the correct
> size. Also it means that most third party XS code doesn't need to be aware
> of copy on write - if it happens to call SvGROW to ensure that a buffer is
> large enough before writing to it, then it would automatically do the
> copy.

BTW I notice that SvIsCOW is not documented in perlapi.pod. That's un-nice.

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About