Front page | perl.perl5.porters |
Postings from March 2003
On Fri 21 Mar 2003 06:03, "Craig A. Berry" <craigberry@mac.com> wrote: > Thanks to those who replied to my query about readdir and thread safety. > I've dug around a bit, read the POSIX spec for readdir_r, and come up > with the implementation in the attached patch. It basically just adds a > mutex gizmo to the directory stream structure and puts a lock on it > while calling the ordinary readdir and assigning return values. All > tests pass with a threaded build of this on top of maintperl@19035 > (though they did before the patch as well). > > To really stress test this with multiple threads going after the same > directory stream I'd need an SMP machine to test on, which I don't have. > But I think we are at least somewhat safer than we were before. Thanks, applied as change #19042 > The affected files are: > > configure.com > vms/vms.c > vms/vmsish.h Can you re-sync and check if it went as you expected? patching file configure.com patching file vms/vms.c Hunk #1 succeeded at 4791 (offset -36 lines). Hunk #2 succeeded at 4845 (offset -36 lines). Hunk #3 succeeded at 4876 (offset -36 lines). Hunk #4 succeeded at 4994 (offset -36 lines). patching file vms/vmsish.h -- H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/) using perl-5.6.1, 5.8.0 & 633 on HP-UX 10.20 & 11.00, AIX 4.2, AIX 4.3, WinNT 4, Win2K pro & WinCE 2.11. Smoking perl CORE: smokers@perl.org http://archives.develooper.com/daily-build@perl.org/ perl-qa@perl.org send smoke reports to: smokers-reports@perl.org, QA: http://qa.perl.orgThread Previous | Thread Next