develooper Front page | perl.perl5.porters | Postings from March 2003

[PATCH embed.fnc] Re: [PATCH] Get MSWin32 back compiling

Thread Previous | Thread Next
From:
Abe Timmerman
Date:
March 1, 2003 11:01
Subject:
[PATCH embed.fnc] Re: [PATCH] Get MSWin32 back compiling
Message ID:
200303011957.41628.abe@ztreet.demon.nl
Op een zonnige winterdag (Saturday 01 March 2003 14:49), schreef Nicholas 
Clark:
> On Sat, Mar 01, 2003 at 04:31:19AM +0100, Abe Timmerman wrote:
> > Well today has been a fruitful day and it looks like Win32 is back to
> > compiling order [for the default configuration, on gcc 3.2].
> > (smoke started, will report back)
> >
> > Sarathy's suggestion for a patch to go on top of change 18725
> > "API functions must also have an A-flag in F<embed.fnc>"
> >
> > -po	|void	|sv_free2	|SV* sv
> > +Apo	|void	|sv_free2	|SV* sv
> >  pd	|void	|sv_free_arenas
> >  Apd	|char*	|sv_gets	|SV* sv|PerlIO* fp|I32 append
> >  Apd	|char*	|sv_grow	|SV* sv|STRLEN newlen
> >
> I have no objection to this as a quick fix, but I'd strongly prefer a flag
> to mean "exported but private". I'd like us to retain the ability to change
> the implementation of the inline SvREFCNT_dec at some point in the future
> including dropping sv_free2 at the next point of binary incompatibility.

I'm afraid that here's another one to get "PERL_COPY_ON_WRITE" compiling 
[needs regen_headers again]. (Another smoke started.)

--- ../perl-current/embed.fnc	2003-03-01 10:27:57.000000000 +0100
+++ embed.fnc	2003-03-01 18:46:48.000000000 +0100
@@ -945,7 +945,7 @@
 Ap |char * |custom_op_desc|OP* op
 
 #if defined(PERL_COPY_ON_WRITE)
-pM	|int	|sv_release_IVX	|SV *sv
+ApM	|int	|sv_release_IVX	|SV *sv
 #endif
 
 Adp	|void	|sv_nosharing	|SV *

Good luck,

Abe
-- 
"Jarkko Hietaniemi" is actually the code name for a whole team of Finnish
super-programmers, capable of working continuously 25 hours a day without
tripping each other up, and running solely only on intravenous caffeine.
                                      -- Nicholas Clark on p5p @ 2002-03-04


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About