develooper Front page | perl.perl5.porters | Postings from March 2003

Re: [PATCH] Get MSWin32 back compiling

Thread Previous | Thread Next
From:
Nicholas Clark
Date:
March 1, 2003 05:52
Subject:
Re: [PATCH] Get MSWin32 back compiling
Message ID:
20030301134940.GB284@Bagpuss.unfortu.net
On Fri, Feb 28, 2003 at 05:32:20PM -0800, Gurusamy Sarathy wrote:
> On Fri, 28 Feb 2003 22:22:50 GMT, Nicholas Clark wrote:
> >Well, it is part of the COW changes. What doesn't make sense is that based on
> >its line in embed.fnc and what Sarathy said:
> >
> >po      |void   |sv_free2       |SV* sv
> >
> >I can't see why it's not already being exported for Win32
> 
> If you wade through makedef.pl, you'll see it simply uses
> the symbols placed in the *.sym files.  Only the symbols that are
> part of the public API get put in the *.sym files by embed.pl.
> Ergo, you need an 'A' flag there for sv_free2() for C.xs to be
> able to see it.

Except that that makes it part of the public API. And I did not intend it to
be part of the public API. I put it in as implementation detail that may
change without warning.

On Sat, Mar 01, 2003 at 04:31:19AM +0100, Abe Timmerman wrote:

> Well today has been a fruitful day and it looks like Win32 is back to 
> compiling order [for the default configuration, on gcc 3.2]. 
> (smoke started, will report back)

> Sarathy's suggestion for a patch to go on top of change 18725
> "API functions must also have an A-flag in F<embed.fnc>"

> -po	|void	|sv_free2	|SV* sv
> +Apo	|void	|sv_free2	|SV* sv
>  pd	|void	|sv_free_arenas
>  Apd	|char*	|sv_gets	|SV* sv|PerlIO* fp|I32 append
>  Apd	|char*	|sv_grow	|SV* sv|STRLEN newlen
> 
> and Adi's patch to go on top of change 18785
> It was suggested that this was a typo/c-n-p error
> 
> --- ../perl-current/perl.h	2003-02-26 03:50:55.000000000 +0100
> +++ perl.h	2003-02-28 02:52:29.000000000 +0100
> @@ -4229,7 +4229,7 @@
>  #ifndef PERL_BLOCKSIG_BLOCK

I have no objection to this as a quick fix, but I'd strongly prefer a flag
to mean "exported but private". I'd like us to retain the ability to change
the implementation of the inline SvREFCNT_dec at some point in the future
including dropping sv_free2 at the next point of binary incompatibility.

Nicholas Clark

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About