develooper Front page | perl.perl5.porters | Postings from February 2003

Re: remaining signedness issue in Encode 1.88

Thread Previous | Thread Next
From:
Craig A. Berry
Date:
February 27, 2003 13:23
Subject:
Re: remaining signedness issue in Encode 1.88
Message ID:
a05200f16ba8431ea2ee0@[172.16.52.1]
At 6:37 PM +0900 2/27/03, Dan Kogai wrote:
>On Thursday, Feb 27, 2003, at 16:56 Asia/Tokyo, Dan Kogai wrote:
>>On Wednesday, Feb 26, 2003, at 14:49 Asia/Tokyo, Craig A. Berry wrote:
>>>it seems like it would be a good idea to protect against that even if
>>>it's not supposed to happen.
>>
>>I do agree with that.  The question is how...
>
>Craig,
>
>  Would you try the patch below ?  Instead of typecasting I now made sure that slen is never negative.  Already passed 'make test' here.
>
>--- Encode.xs   2003/02/20 14:42:34     1.54
>+++ Encode.xs   2003/02/27 09:32:04

That compiles without warnings and passes all tests for me.  Thanks.

-- 
________________________________________
Craig A. Berry
mailto:craigberry@mac.com

"... getting out of a sonnet is much more
 difficult than getting in."
                 Brad Leithauser

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About