Front page | perl.perl5.porters |
Postings from February 2003
Re: [perl@18752] warnings from CGI tests under cygwin
Thread Previous
|
Thread Next
From:
H.Merijn Brand
Date:
February 25, 2003 05:23
Subject:
Re: [perl@18752] warnings from CGI tests under cygwin
Message ID:
20030225142132.2BA2.H.M.BRAND@hccnet.nl
On Wed 19 Feb 2003 22:37, sthoenna@efn.org (Yitzchak Scott-Thoennes) wrote:
> Several of the CGI tests are spewing warnings:
>
> lib/CGI/t/form.......................Use of uninitialized value in concatenation (.) or string at ../lib/CGI.pm line 3459.
> Use of uninitialized value in concatenation (.) or string at ../lib/CGI.pm line 3459.
> Use of uninitialized value in concatenation (.) or string at ../lib/CGI.pm line 3459.
> Use of uninitialized value in concatenation (.) or string at ../lib/CGI.pm line 3459.
> Use of uninitialized value in concatenation (.) or string at ../lib/CGI.pm line 3459.
> Use of uninitialized value in concatenation (.) or string at ../lib/CGI.pm line 3459.
> Use of uninitialized value in concatenation (.) or string at ../lib/CGI.pm line 3459.
> Use of uninitialized value in concatenation (.) or string at ../lib/CGI.pm line 3459.
> Use of uninitialized value in concatenation (.) or string at ../lib/CGI.pm line 3459.
> Use of uninitialized value in concatenation (.) or string at ../lib/CGI.pm line 3459.
> Use of uninitialized value in concatenation (.) or string at ../lib/CGI.pm line 3459.
> Use of uninitialized value in concatenation (.) or string at ../lib/CGI.pm line 3459.
> ok
>
> Sometime between CGI version 2.81 and 2.89, $CGI::OS changed to 'CYGWIN'
> instead of 'UNIX', breaking the code setting $CGI::SL.
>
> Not sure where to put a test for this; perhaps CGI.pm should just croak if
> $SL is undefined after the assignment.
Thanks, applied with minor reformatting as change #18772:
Change 18772 by merijn@merijn-l1 on 2003/02/25 12:12:14
Subject: [perl@18752] warnings from CGI tests under cygwin
From: sthoenna@efn.org (Yitzchak Scott-Thoennes)
Date: Wed, 19 Feb 2003 13:37:39 -0800
Message-ID: <jk/U+gzkg2DE092yn@efn.org>
Affected files ...
... //depot/perl/lib/CGI.pm#36 edit
Differences ...
==== //depot/perl/lib/CGI.pm#36 (text) ====
152,153c152,153
< UNIX=>'/', OS2=>'\\', EPOC=>'/',
< WINDOWS=>'\\', DOS=>'\\', MACINTOSH=>':', VMS=>'/'
---
> UNIX => '/', OS2 => '\\', EPOC => '/', CYGWIN => '/',
> WINDOWS => '\\', DOS => '\\', MACINTOSH => ':', VMS => '/'
> --- perl/lib/CGI.pm.orig Thu Jan 16 13:25:44 2003
> +++ perl/lib/CGI.pm Wed Feb 19 13:35:50 2003
> @@ -149,7 +149,7 @@
> # The path separator is a slash, backslash or semicolon, depending
> # on the paltform.
> $SL = {
> - UNIX=>'/', OS2=>'\\', EPOC=>'/',
> + UNIX=>'/', OS2=>'\\', EPOC=>'/', CYGWIN=>'/',
> WINDOWS=>'\\', DOS=>'\\', MACINTOSH=>':', VMS=>'/'
> }->{$OS};
>
> End of Patch.
--
H.Merijn Brand Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using perl-5.6.1, 5.8.0 & 633 on HP-UX 10.20 & 11.00, AIX 4.2, AIX 4.3,
WinNT 4, Win2K pro & WinCE 2.11. Smoking perl CORE: smokers@perl.org
http://archives.develooper.com/daily-build@perl.org/ perl-qa@perl.org
send smoke reports to: smokers-reports@perl.org, QA: http://qa.perl.org
Thread Previous
|
Thread Next