develooper Front page | perl.perl5.porters | Postings from February 2003

[PATCH: perl@186389] add probe for yet another dangerous logical name: COMP

Thread Next
From:
PPrymmer
Date:
February 19, 2003 12:23
Subject:
[PATCH: perl@186389] add probe for yet another dangerous logical name: COMP
Message ID:
OFC0A627AD.02B9D968-ON85256CD2.006DDC21@factset.com
Greetings,

In running the test suite for perl@186389 I encountered
failed tests for:

lib/ExtUtils/t/Installed.............FAILED at test 47

and it turns out that a warning issued by File::Find
was the culprit.  It turns out that File::Find was complaining
about an inability to cd into the t/comp directory.
The reason that it could not do that is because I had a
COMP logical name defined in my environment.

The enclosed patch adds a probe and warning for the
COMP logical name to configure.com and also updates
the README.vms file to better match the logical names that
have built up in configure.com.

diff -ru perl_186389/README.vms perl/README.vms
--- perl_186389/README.vms    Thu Jan 23 09:20:34 2003
+++ perl/README.vms     Wed Feb 19 14:57:38 2003
@@ -176,12 +176,22 @@
 otherwise simply deassign the dangerous logical names.  The potentially
 troublesome logicals and symbols are:

-    TMP  "LOGICAL"
-    LIB  "LOGICAL"
-    T    "LOGICAL"
-    FOO  "LOGICAL"
-    EXT  "LOGICAL"
-    TEST "SYMBOL"
+    COMP    "LOGICAL"
+    EXT     "LOGICAL"
+    FOO     "LOGICAL"
+    LIB     "LOGICAL"
+    LIST    "LOGICAL"
+    MIME    "LOGICAL"
+    POSIX   "LOGICAL"
+    SYS     "LOGICAL"
+    T       "LOGICAL"
+    THREAD  "LOGICAL"
+    THREADS "LOGICAL"
+    TIME    "LOGICAL"
+    TMP     "LOGICAL"
+    UNICODE "LOGICAL"
+    UTIL    "LOGICAL"
+    TEST    "SYMBOL"

 As a handy shortcut, the command:

diff -ru perl_186389/configure.com perl/configure.com
--- perl_186389/configure.com Thu Jan 23 09:20:37 2003
+++ perl/configure.com  Wed Feb 19 14:57:55 2003
@@ -6297,6 +6297,7 @@
 $ ENDSUBROUTINE ! Bad_environment
 $ echo ""
 $ echo4 "Checking for dangerous pre-existing global symbols and logical names."
+$ CALL Bad_environment "COMP"
 $ CALL Bad_environment "EXT"
 $ CALL Bad_environment "FOO"
 $ CALL Bad_environment "LIB"
End of Patch.

Peter Prymmer



Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About