Re: [PATCH 5.9.0] to silence compiler warning

Robin Barker <Robin.Barker@npl.co.uk> wrote:
:
:Patch against 18376.
:
:scalar.xs	wrap assignment in if
:Storable.xs	remove repeated use of PL_na
:universal.c	use SVf (to hide %_ from -Wformat)
:util.c	format uniformity

Thanks, applied as change #18697, along with additional PL_na removals
from Storable.xs.

It occurs to me just after checking this in that Storable might want
to work on versions that predate SvPV_nolen. If so, that chunk of the
change should be reversed, and the original problem case around l5011:
  CROAK(("code %s caused an error: %s", SvPV(sub, PL_na), SvPV(errsv, PL_na)));
should declare itself a PL_na2 instead.

Hugo

• [PATCH 5.9.0] to silence compiler warning by Robin Barker
• Re: [PATCH 5.9.0] to silence compiler warning by hv