[perl #20818] PPM v2.1.6 bug wrt multiple repositories

# New Ticket Created by  "David P. Mott" 
# Please include the string:  [perl #20818]
# in the subject line of all future correspondence about this issue. 
# <URL: http://rt.perl.org/rt2/Ticket/Display.html?id=20818 >


This is a bug report for perl from dpmott@sep.com,
generated with the help of perlbug 1.33 running under perl v5.6.1.


Synopsis:
  PPM can inadvertantly skip some repositories when searching via a
  specified summary file.

Location:
   in ppm.pm
      in sub RepositorySummary
         these two lines form a bug:
           if ($location =~ /\Q$repositories{$_}{'LOCATION'}\E/i) {
                $locations{$repositories{$_}{'LOCATION'}} =
         it should be:
           if ($location =~ /^\Q$repositories{$_}{'LOCATION'}\E$/i) {
                $locations{$repositories{$_}{'LOCATION'}} =
         or at least:
           if ($location =~ /\Q$repositories{$_}{'LOCATION'}\E$/i) {
                $locations{$repositories{$_}{'LOCATION'}} =
         or even this
         (but this would be a different but for the same reason...):
           if ($location =~ /\Q$repositories{$_}{'LOCATION'}\E/i) {
                $locations{$$location} =

Example:
   In my case, I had two repositories:
      http://gandalf/PPMPackages/5.6
      http://gandalf/PPMPackages/5.6plus

Debugging showed that when the location was the ".../5.6plus" repository,
the if() conditional above would be true when (in the surrounding for()
loop) the $_ variable was on the ".../5.6" repository.  This is an
incorrect match.  The result is that the incorrect repository location was
loaded into the %locations hash.

The end result is that the ".../5.6" repository was seached twice, and the
".../5.6" repository was never searched.

Please not that this pathway is not executed if the server is running SOAP
and is servicing server-side searches.

Version Information:
   I'm using PPM v2.1.6

---
Flags:
    category=core
    severity=low
---
Site configuration information for perl v5.6.1:

Configured by ActiveState at Mon Jun 17 21:32:50 2002.

Summary of my perl5 (revision 5 version 6 subversion 1) configuration:
  Platform:
    osname=MSWin32, osvers=4.0, archname=MSWin32-x86-multi-thread
    uname=''
    config_args='undef'
    hint=recommended, useposix=true, d_sigaction=undef
    usethreads=undef use5005threads=undef useithreads=define usemultiplicity=define
    useperlio=undef d_sfio=undef uselargefiles=undef usesocks=undef
    use64bitint=undef use64bitall=undef uselongdouble=undef
  Compiler:
    cc='cl', ccflags ='-nologo -O1 -MD -DNDEBUG -DWIN32 -D_CONSOLE -DNO_STRICT -DHAVE_DES_FCRYPT  -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS -DPERL_MSVCRT_READFIX',
    optimize='-O1 -MD -DNDEBUG',
    cppflags='-DWIN32'
    ccversion='', gccversion='', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=undef, longlongsize=8, d_longdbl=define, longdblsize=10
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=4
    alignbytes=8, usemymalloc=n, prototype=define
  Linker and Libraries:
    ld='link', ldflags ='-nologo -nodefaultlib -release  -libpath:"D:/Perl\lib\CORE"  -machine:x86'
    libpth="D:\Program Files\Microsoft Visual Studio .NET\FrameworkSDK\Lib\" "D:\Perl\lib\CORE"
    libs=  oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib  comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib  netapi32.lib uuid.lib wsock32.lib mpr.lib winmm.lib  version.lib odbc32.lib odbccp32.lib msvcrt.lib
    perllibs=  oldnames.lib kernel32.lib user32.lib gdi32.lib winspool.lib  comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib  netapi32.lib uuid.lib wsock32.lib mpr.lib winmm.lib  version.lib odbc32.lib odbccp32.lib msvcrt.lib
    libc=msvcrt.lib, so=dll, useshrplib=yes, libperl=perl56.lib
  Dynamic Linking:
    dlsrc=dl_win32.xs, dlext=dll, d_dlsymun=undef, ccdlflags=' '
    cccdlflags=' ', lddlflags='-dll -nologo -nodefaultlib -release  -libpath:"D:/Perl\lib\CORE"  -machine:x86'

Locally applied patches:
    ACTIVEPERL_LOCAL_PATCHES_ENTRY

---
@INC for perl v5.6.1:
    d:/Perl/lib
    d:/Perl/site/lib
    .

---
Environment for perl v5.6.1:
    HOME (unset)
    LANG (unset)
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=D:\oracle\ora92\bin;C:\Program Files\Oracle\jre\1.3.1\bin;C:\Program Files\Oracle\jre\1.1.8\bin;D:\Perl\bin\;D:\Perl\bin\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;D:\Program Files\Support Tools\;d:\bin;d:\mybin;D:\Program Files\Rational\ClearCase\netinst2002\bin
    PERLDB_OPTS=RemotePort=127.0.0.1:2000
    PERL_BADLANG (unset)
    SHELL (unset)

• [perl #20818] PPM v2.1.6 bug wrt multiple repositories by David P. Mott