develooper Front page | perl.perl5.porters | Postings from February 2003

Re: [perl #20606] [PATCH} openbsd hints

Thread Previous | Thread Next
From:
H.Merijn Brand
Date:
February 3, 2003 09:25
Subject:
Re: [perl #20606] [PATCH} openbsd hints
Message ID:
20030203182350.C582.H.M.BRAND@hccnet.nl
On Sun 02 Feb 2003 18:27, Abe Timmerman <abe@ztreet.demon.nl> wrote:
> Op een druilerige winterdag (Sunday 02 February 2003 18:22), schreef Abe Timmerman:
> 
> > Op een druilerige winterdag (Sunday 02 February 2003 04:22), schreef Todd C. Miller:
> > > In message <rt-20606-50012.14.7796026894771@bugs6.perl.org>
> > >
> > > 	so spake Abe Timmerman (perlbug-followup):
> > > > I have now confirmed that this patch breaks my openbsd-smokes.
> > > >
> > > > I don't know what this is all about, so I can't be of any real help,
> > > > other than trying suggestions...
> > >
> > > Well perl-current works fine for me on OpenBSD-current/i386 and
> > > passes all tests.  I don't know what your openbsd-smokes are :-).
> > > I'll try it on an OpenBSD 3.2 machine soon.  Well, relatively soon
> > > as I'm going to be out of town for the next 6 days.
> > >
> > > If you want to mail me some details as to what actually breaks that
> > > would be helpful.
> >
> > I have put back the change from "-lc" to "-lc_r" under usethreads for
> > osvers <= 3.2 here's my patch on top of yours, I hope this is okay for you
> > as well:
> 
> And it helps if I include the patch (also attached, 'cause of long line)
> 
> --- hints/openbsd.sh.orig	Sun Feb  2 14:26:12 2003
> +++ hints/openbsd.sh	Sun Feb  2 18:16:35 2003
> @@ -104,6 +104,12 @@
>  	# any openbsd version dependencies with pthreads?
>  	ccflags="-pthread $ccflags"
>  	ldflags="-pthread $ldflags"
> +	case "$osvers" in
> +	[0-2].*|3.[0-2])
> +		# Change from -lc to -lc_r
> +		libswanted=`echo " $libswanted "| sed -e 's/ c / c_r /' -e 's/^ //' -e 's/ $//'`
> +	;;
> +	esac
>  esac
>  EOCBU

In order to stay in the same way all (most) libswanted's are changed, I've
applied it in change #18647 like this:

Change 18647 by merijn@merijn-l1 on 2003/02/03 16:14:00

        Subject: Re: [perl #20606] [PATCH} openbsd hints
        From: Abe Timmerman <abe@ztreet.demon.nl>
        Date: Sun, 2 Feb 2003 18:27:57 +0100
        Message-Id: <200302021827.57240.abe@ztreet.demon.nl>

Affected files ...

... //depot/perl/hints/openbsd.sh#18 edit

Differences ...

==== //depot/perl/hints/openbsd.sh#18 (text) ====

106a107,114
>       case "$osvers" in
>       [0-2].*|3.[0-2])
>               # Change from -lc to -lc_r
>               set `echo "X $libswanted " | sed 's/ c / c_r /'`
>               shift
>               libswanted="$*"
>       ;;
>       esac

-- 
H.Merijn Brand        Amsterdam Perl Mongers (http://amsterdam.pm.org/)
using perl-5.6.1, 5.8.0 & 633 on HP-UX 10.20 & 11.00, AIX 4.2, AIX 4.3,
  WinNT 4, Win2K pro & WinCE 2.11.  Smoking perl CORE: smokers@perl.org
http://archives.develooper.com/daily-build@perl.org/   perl-qa@perl.org
send smoke reports to: smokers-reports@perl.org, QA: http://qa.perl.org



Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About