develooper Front page | perl.perl5.porters | Postings from February 2003

Re: [perl #18232] [PATCH] store PL_reg_match_utf8 in reganch

Thread Previous
From:
Jarkko Hietaniemi
Date:
February 2, 2003 10:02
Subject:
Re: [perl #18232] [PATCH] store PL_reg_match_utf8 in reganch
Message ID:
20030202180229.GE2975@kosh.hut.fi
> The following patch fixes bug #18232. The bug is that the utf8 flag on
> $<digit> variables is dropped when an inner scope also modifies the
> $<digit> vars. (See the included regression test.) That's because this
> flag is stored in a global variable PL_reg_match_utf8.
> 
> I don't get rid completely of PL_reg_match_utf8 but I duplicate it with
> a new flag in regexp.reganch. PL_reg_match_utf8 is still used in
> regexec.c to avoid the need to carry on the current regexp everywhere.
> I suspect this is also more efficient.

Looks good to me (and I was adding stuff to pat.t anyway), and I like
it (for maint) since binary compat is preserved (PL_reg_match_utf8
isn't completely removed).  So applied as change #18633.

-- 
Jarkko Hietaniemi <jhi@iki.fi> http://www.iki.fi/jhi/ "There is this special
biologist word we use for 'stable'.  It is 'dead'." -- Jack Cohen

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About