develooper Front page | perl.perl5.porters | Postings from January 2003

Re: Smoke [5.9.0] 18609 FAIL(F) MSWin32 5.1 (x86/1 cpu)

Thread Previous | Thread Next
From:
Enache Adrian
Date:
January 31, 2003 21:17
Subject:
Re: Smoke [5.9.0] 18609 FAIL(F) MSWin32 5.1 (x86/1 cpu)
Message ID:
20030201052409.GA1948@ratsnest.hole
On Sat, Feb 01, 2003 at 03:38:26AM +0100, Abe Timmerman wrote:
> Op een sneeuwerige winterdag (Friday 31 January 2003 23:44), schreef XPFikkie:
> 
> Could the failing of "run/switches.t":6 have to do with:
> 
> 	* Change 18580: patch to speed up Perl's slurp mode
> (It fails for all builds)

I don't think so.

The test also fails on Linux when setting PERLIO=:crlf , and
here I positively know that it isn't my patch fault ( When
the file is a pipe - as at t/run/switches.t:60 , it just does
things the old way ).

However I don't have access to a Window system.
Could try please try this (it completely disables my hack)
and see if it makes any difference on Windows ?
----------------------------------------------------------------------
--- /arc/perl-current/sv.c	2003-01-30 11:15:10.000000000 +0200
+++ sv.c	2003-02-01 07:05:42.000000000 +0200
@@ -6173,10 +6173,12 @@
 	rslen = 1;
     }
     else if (RsSNARF(PL_rs)) {
+	/*
 	Stat_t st;
 	if (!PerlLIO_fstat(PerlIO_fileno(fp), &st) && st.st_size
 		&& (recsize = st.st_size - PerlIO_tell(fp)))
 	    goto read_record;
+	 */
 	rsptr = NULL;
 	rslen = 0;
     }
-----------------------------------------------------------------------

Thanks & Regards
Adi

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About