develooper Front page | perl.perl5.porters | Postings from January 2003

[PATCH] Re: [perl #9394] Re: [ID 20020525.002] coredump/ bad free warning in blead with SIGWARN

From:
Nicholas Clark
Date:
January 21, 2003 14:32
Subject:
[PATCH] Re: [perl #9394] Re: [ID 20020525.002] coredump/ bad free warning in blead with SIGWARN
Message ID:
20030121222720.GG293@Bagpuss.unfortu.net
On Sat, Jan 18, 2003 at 06:07:14PM +0000, Nick Ing-Simmons wrote:
> Nicholas Clark <nick@unfortu.net> writes:
> >
> >I think that the READONLY test should go. Any reason why it must stay?
> 
> Can't see one so far.

This passes all tests for a normal, and ithreads with
 -DPERL_COPY_OR_WRITE -DDEBUGGING

Nicholas Clark

--- sv.c.orig	Thu Jan 16 21:45:54 2003
+++ sv.c	Mon Jan 20 20:49:55 2003
@@ -7616,7 +7616,9 @@ Perl_sv_unref_flags(pTHX_ SV *sv, U32 fl
     }
     SvRV(sv) = 0;
     SvROK_off(sv);
-    if (SvREFCNT(rv) != 1 || SvREADONLY(rv) || (flags & SV_IMMEDIATE_UNREF))
+    /* You can't have a || SvREADONLY(rv) here, as $a = $$a, where $a was
+       assigned to as BEGIN {$a = \"Foo"} will fail.  */
+    if (SvREFCNT(rv) != 1 || (flags & SV_IMMEDIATE_UNREF))
 	SvREFCNT_dec(rv);
     else /* XXX Hack, but hard to make $a=$a->[1] work otherwise */
 	sv_2mortal(rv);		/* Schedule for freeing later */
--- t/op/ref.t.orig	Mon Aug 12 13:48:39 2002
+++ t/op/ref.t	Mon Jan 20 21:14:10 2003
@@ -5,7 +5,7 @@ BEGIN {
     @INC = qw(. ../lib);
 }
 
-print "1..63\n";
+print "1..65\n";
 
 require 'test.pl';
 
@@ -296,23 +296,44 @@ $a = $a->[1];
 print "not " unless $a == 2;
 print "ok 55\n";
 
-sub x::DESTROY {print "ok ", 55 + shift->[0], "\n"}
-{ my $a1 = bless [4],"x";
-  my $a2 = bless [3],"x";
-  { my $a3 = bless [2],"x";
-    my $a4 = bless [1],"x";
-    567;
+# This test used to coredump. The BEGIN block is important as it causes the
+# op that created the constant reference to be freed. Hence the only
+# reference to the constant string "pass" is in $a. The hack that made
+# sure $a = $a->[1] would work didn't work with references to constants.
+
+my $test = 56;
+
+foreach my $lexical ('', 'my $a; ') {
+  my $expect = "pass\n";
+  my $result = runperl (switches => ['-wl'], stderr => 1,
+    prog => $lexical . 'BEGIN {$a = \q{pass}}; $a = $$a; print $a');
+
+  if ($? == 0 and $result eq $expect) {
+    print "ok $test\n";
+  } else {
+    print "not ok $test # \$? = $?\n";
+    print "# expected ", _qq ($expect), ", got ", _qq ($result), "\n";
   }
+  $test++;
 }
 
+sub x::DESTROY {print "ok ", $test + shift->[0], "\n"}
+{ my $a1 = bless [3],"x";
+  my $a2 = bless [2],"x";
+  { my $a3 = bless [1],"x";
+    my $a4 = bless [0],"x";
+    567;
+  }
+}
+$test+=4;
 
 my $result = runperl (switches=>['-l'],
                       prog=> 'print 1; print qq-*$\*-;print 1;');
 my $expect = "1\n*\n*\n1\n";
 if ($result eq $expect) {
-  print "ok 60\n";
+  print "ok $test\n";
 } else {
-  print "not ok 60\n";
+  print "not ok $test\n";
   foreach ($expect, $result) {
     s/\n/\\n/gs;
   }
@@ -321,7 +342,7 @@ if ($result eq $expect) {
 
 # test global destruction
 
-my $test = 61;
+++$test;
 my $test1 = $test + 1;
 my $test2 = $test + 2;
 



nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About