develooper Front page | perl.perl5.porters | Postings from January 2003

Re: maint snapshot

Thread Previous | Thread Next
From:
Autrijus Tang
Date:
January 1, 2003 00:39
Subject:
Re: maint snapshot
Message ID:
20030101084017.GA1224@not.autrijus.org
On Tue, Dec 31, 2002 at 10:11:19PM +0200, Jarkko Hietaniemi wrote:
> Here's a snapshot from the maint branch, shadowing the blead snapshot.
> 	http://www.iki.fi/jhi/perl@18380.tgz
> 	http://www.iki.fi/jhi/perl@18380.tbz

On FreeBSD 4.7 with default config there's no problem.  All tests pass.

On Win32 with threaded build however, the attached patch seems to be
necessary.  Also, the compiler warned against signed/unsigned mismatch
at line 5356 and similar places, where cachep is compared to uoff.

Thanks,
/Autrijus/

--- sv.c.orig	Wed Jan  1 06:52:30 2003
+++ sv.c	Wed Jan  1 16:37:41 2003
@@ -5309,7 +5309,7 @@
  *
  */
 STATIC bool
-S_utf8_mg_pos_init(SV *sv, MAGIC **mgp, STRLEN **cachep, I32 i, I32 *offsetp, U8 *s, U8 *start)
+S_utf8_mg_pos_init(pTHX_ SV *sv, MAGIC **mgp, STRLEN **cachep, I32 i, I32 *offsetp, U8 *s, U8 *start)
 {
     bool found = FALSE; 
 
@@ -5344,7 +5344,7 @@
  *
  */
 STATIC bool
-S_utf8_mg_pos(SV *sv, MAGIC **mgp, STRLEN **cachep, I32 i, I32 *offsetp, I32 uoff, U8 **sp, U8 *start, U8 *send)
+S_utf8_mg_pos(pTHX_ SV *sv, MAGIC **mgp, STRLEN **cachep, I32 i, I32 *offsetp, I32 uoff, U8 **sp, U8 *start, U8 *send)
 {
     bool found = FALSE;
 
@@ -5469,21 +5469,21 @@
 	 MAGIC *mg = 0;
 	 bool found = FALSE;
 
-         if (S_utf8_mg_pos(sv, &mg, &cache, 0, offsetp, *offsetp, &s, start, send))
+         if (S_utf8_mg_pos(aTHX_ sv, &mg, &cache, 0, offsetp, *offsetp, &s, start, send))
              found = TRUE;
 	 if (!found && uoffset > 0) {
 	      while (s < send && uoffset--)
 		   s += UTF8SKIP(s);
 	      if (s >= send)
 		   s = send;
-              if (S_utf8_mg_pos_init(sv, &mg, &cache, 0, offsetp, s, start))
+              if (S_utf8_mg_pos_init(aTHX_ sv, &mg, &cache, 0, offsetp, s, start))
                   boffset = cache[1];
 	      *offsetp = s - start;
 	 }
 	 if (lenp) {
 	      found = FALSE;
 	      start = s;
-              if (S_utf8_mg_pos(sv, &mg, &cache, 2, lenp, *lenp + *offsetp, &s, start, send)) {
+              if (S_utf8_mg_pos(aTHX_ sv, &mg, &cache, 2, lenp, *lenp + *offsetp, &s, start, send)) {
                   *lenp -= boffset;
                   found = TRUE;
               }
@@ -5494,7 +5494,7 @@
 			     s += UTF8SKIP(s);
 		   if (s >= send)
 			s = send;
-                   if (S_utf8_mg_pos_init(sv, &mg, &cache, 2, lenp, s, start))
+                   if (S_utf8_mg_pos_init(aTHX_ sv, &mg, &cache, 2, lenp, s, start))
 			cache[2] += *offsetp;
 	      }
 	      *lenp = s - start;

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About