develooper Front page | perl.perl5.porters | Postings from December 2001

Re: [PATCH] from the non-ANSI comment police (was: it won't compile on win32)

Thread Previous | Thread Next
From:
Nick Ing-Simmons
Date:
December 29, 2001 13:35
Subject:
Re: [PATCH] from the non-ANSI comment police (was: it won't compile on win32)
Message ID:
20011229213549.15967.11@bactrian.ni-s.u-net.com
H . Merijn Brand <h.m.brand@hccnet.nl> writes:
>On Sat 29 Dec 2001 19:17, Nicholas Clark <nick@unfortu.net> wrote:
>> Presumably this bit of NetWare/nw5.c needs to be promoted to the core in some
>> way that is friends with WIN32?
>> 
>> #ifdef USE_ITHREADS
>> PerlInterpreter *
>> perl_clone_host(PerlInterpreter* proto_perl, UV flags)
>> {
>> 	// Perl Clone is not implemented on NetWare.
>        ^^
>ALARM ALARM !!! Non-ansi comment detected!!!
>
>(Though this is only for NetWare, I don't care. I think I'm going to chase
> down the whole source tree for these ERRORs)
>
>Patch attached. Netware still skipped, because it has sooooooo many wrong
>comments. I'd submit a patch to that buggy way of programming if it is
>requested. (Hint: you should)

Patch looks harmless as C++ has /* */ too.

..../win32/...
are not needed as all Win32 compilers have to handle // as a comment
'cos MS's headers do that. vmem.h et. al. are also only compiled 
as C++ 

-- 
Nick Ing-Simmons
http://www.ni-s.u-net.com/


Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About