develooper Front page | perl.perl5.porters | Postings from December 2001

[ID 20011219.006] patch against IO-1.20.tar.gz

From:
Jeffrey Todd Cours
Date:
December 19, 2001 13:22
Subject:
[ID 20011219.006] patch against IO-1.20.tar.gz
Message ID:
200112192121.NAA03497@flipper.speedtrak.com

This is a bug report for perl from jtcours@routescience.com,
generated with the help of perlbug 1.26 running under perl 5.00503.


-----------------------------------------------------------------
[Please enter your report here]

For a number of reasons, I can't run the latest version of Perl right now.
However, many of the CPAN modules are designed to run with Perl 5.6
rather than Perl 5.00503, so I've had to make a few adjustments to
get things to work properly, especially when Perl 5.00503 doesn't have
the socket timeout feature that Perl 5.6 supports.

This change is to IO::Socket::timeout(). Currently, IO::Socket::timeout()
uses the number of array elements in the @_ array to decide whether or
not to set the Socket's timeout. Unfortunately, Net::FTP::_dataconn()
contains logic that looks like this:

  $data->timeout($ftp->timeout);

where $data and $ftp are both IO::Socket objects. If $ftp->timeout returns
undef, because there is no timeout set, then $data->timeout will see
an @_ array that contains (<socket GLOB>, undef). It then tries to set
${*$sock}{'io_socket_timeout'} to 0 + undef, which triggers a warning.

This modifies the check on timeout's parameter to explicitly look for
undef rather than counting the number of parameters.

diff -Naur IO-1.20/IO/Socket.pm IO-1.20.new/IO/Socket.pm
--- IO-1.20/IO/Socket.pm	Tue Jul 14 03:50:53 1998
+++ IO-1.20.new/IO/Socket.pm	Tue Dec 18 22:04:28 2001
@@ -264,7 +264,7 @@
     my $r = ${*$sock}{'io_socket_timeout'} || undef;
 
     ${*$sock}{'io_socket_timeout'} = 0 + $val
-	if(@_ == 2);
+	if(defined $val);
 
     $r;
 }

[Please do not change anything below this line]
-----------------------------------------------------------------

---
Site configuration information for perl 5.00503:

Configured by root at Wed Feb  2 15:34:50 EST 2000.

Summary of my perl5 (5.0 patchlevel 5 subversion 3) configuration:
  Platform:
    osname=linux, osvers=2.2.5-22smp, archname=i386-linux
    uname='linux porky.devel.redhat.com 2.2.5-22smp #1 smp wed jun 2 09:11:51 edt 1999 i686 unknown '
    hint=recommended, useposix=true, d_sigaction=define
    usethreads=undef useperlio=undef d_sfio=undef
  Compiler:
    cc='cc', optimize='-O2 -m486 -fno-strength-reduce', gccversion=egcs-2.91.66 19990314/Linux (egcs-1.1.2 release)
    cppflags='-Dbool=char -DHAS_BOOL -I/usr/local/include'
    ccflags ='-Dbool=char -DHAS_BOOL -I/usr/local/include'
    stdchar='char', d_stdstdio=undef, usevfork=false
    intsize=4, longsize=4, ptrsize=4, doublesize=8
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    alignbytes=4, usemymalloc=n, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -L/usr/local/lib'
    libpth=/usr/local/lib /lib /usr/lib
    libs=-lnsl -ldl -lm -lc -lposix -lcrypt
    libc=, so=so, useshrplib=false, libperl=libperl.a
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-rdynamic'
    cccdlflags='-fpic', lddlflags='-shared -L/usr/local/lib'

Locally applied patches:
    

---
@INC for perl 5.00503:
    /n/build/jtcours/trunk/src/perftest/perlinst
    /n/build/jtcours/trunk/lib/perl5
    /usr/lib/perl5/5.00503/i386-linux
    /usr/lib/perl5/5.00503
    /usr/lib/perl5/site_perl/5.005/i386-linux
    /usr/lib/perl5/site_perl/5.005
    .

---
Environment for perl 5.00503:
    HOME=/h/jtcours
    LANG=en_US
    LANGUAGE (unset)
    LD_LIBRARY_PATH=/n/build/jtcours/trunk/lib:/n/build/jtcours/trunk/opt/TimesTen4.1/32/lib:/opt/rs-hd/opt/TimesTen4.1/32/lib
    LOGDIR (unset)
    PATH=/n/util/java/external/jdk1.3.0_02/bin:/n/util/bin:/n/common/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/X11R6/bin:/usr/bin:/usr/sbin:/usr/dt/bin:/usr/openwin/bin:/usr/bin/X11:/usr/local/bin:/usr/proc/bin:/usr/ccs/bin:/usr/ucb:/h/brian/work/insure++-6.0-beta/bin.linux2:/h/jtcours/bin
    PERLLIB=/n/build/jtcours/trunk/src/perftest/perlinst:/n/build/jtcours/trunk/lib/perl5
    PERL_BADLANG (unset)
    SHELL=/bin/bash




nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About