develooper Front page | perl.perl5.porters | Postings from October 2001

Re: [PATCH hints/] Examining Redhat patches

Thread Previous | Thread Next
Jarkko Hietaniemi
October 27, 2001 09:02
Re: [PATCH hints/] Examining Redhat patches
Message ID:
> The include Digest::MD5, we include Digest::MD5.  Good.
> perl-5.6.0-errno.patch tears out get_files() and process_file() and
> replaces it with a very RH specific get_errors() which goes through
> the defines in errno.h.  I'm curious why the original functions didn't
> work.  Patch attached.

I'm curious, too, and the carefree ripping out breaks things for
pretty much everybody else (non-gcc, and not even all gcc setups
will work, e.g. Mac OS X has some extra hacks, IIRC).

Yes, I do I fully understand that Redhat specific changes are Redhat
specific changes and that they are not even supposed to work as-is
with the core distribution.

> >From perl-5.6.0-fhs.patch below is a small correction to
> hints/ that RH uses -devel not -dev.

I guess this has changed at some point in RH history, so
maybe we need to switch on RH version.  Yes, people are still
running RH 5... 

> perl-5.6.0-nodb.patch seems to be thrashing around making NDBM_File
> working with... something.  I've attached it if someone wants to
> figure out if it's useful.

/usr/include/db1 looks pretty RedHat-specific, whatever it is.  Using
ext/NDBM_File/hints/ and switching on RHness would have been
more contained... but of course we would need to figure out first,
what it is :-) If it is something more widely useful, we can adopt it.

> perl-5.6.0-prereq.patch is a very coarse hack to have Makemaker dump
> out the module prereqs and then exit.  Something like this might be
> useful as perhaps a make target or MakeMaker function.  Attached.

This looks like a reasonable idea.

> perl-5.6.0-syslog.patch looks like it's adding syslog logging to
> validate_suid().  It looks like a lot of the code it's emulating (like
> sending mail to root) is gone.  I've attached it for someone more
> knowledgable about suid to evaluate.

Could work, though I'm not that excited to touch the suidperl code
in any way, shape, or form.  It's not a can of worms, it's a tank
of shai-hulud.

$jhi++; #
        # There is this special biologist word we use for 'stable'.
        # It is 'dead'. -- Jack Cohen

Thread Previous | Thread Next Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About