develooper Front page | perl.perl5.porters | Postings from September 2001

Re: Report /pro/3gl/CPAN/perl-current@11794

Thread Previous | Thread Next
From:
Michael G Schwern
Date:
September 3, 2001 08:13
Subject:
Re: Report /pro/3gl/CPAN/perl-current@11794
Message ID:
20010903111314.K9233@blackrider
On Mon, Sep 03, 2001 at 03:37:57PM +0100, Nicholas Clark wrote:
> so it looks like your cwd doesn't taint on 10.20. Next question: Why?
> File/Find.pm looks confusing, but am I right in thinking that you get
> 
>     my $cwd            = $wanted->{bydepth} ? Cwd::fastcwd() : Cwd::cwd();

Why the hell is the selection of fastcwd vs cwd dependent on whether
or not we're searching by depth???

Anyhow, cwd() isn't taint clean here, either (Debian/PowerPC).
fastcwd() and getcwd() are.


IMHO just change that logic to

    my $cwd = $wanted->{bydepth} ? Cwd::fastcwd() : Cwd::getcwd();


-- 

Michael G. Schwern   <schwern@pobox.com>    http://www.pobox.com/~schwern/
Perl6 Quality Assurance     <perl-qa@perl.org>	     Kwalitee Is Job One
You will feel tremendous pain at the area where foreign materials are inserted.
I usually don't recommend anyone to insert artificial materials.  Keep
everything natural is best!
	     --Alex Chiu, Immortality Guy

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About