develooper Front page | perl.perl5.porters | Postings from August 2001

Re: [PATCH 2 of 3] $] is deprecated - EXTERMINATE, EXTERMINATE, EXTERMINATE

Thread Previous | Thread Next
From:
John Peacock
Date:
August 23, 2001 06:18
Subject:
Re: [PATCH 2 of 3] $] is deprecated - EXTERMINATE, EXTERMINATE, EXTERMINATE
Message ID:
3B850091.11BA3E3B@rowman.com
Philip Newton wrote:
> 
> On Mon, 20 Aug 2001 21:45:49 -0400, jpeacock@rowman.com (John Peacock) wrote:
> 
> > -# $], $^O, $^T
> > -ok 26, $] >= 5.00319, $];
> > +# $^V, $^O, $^T
> > +ok 26, $^V gt 5.3.19, $];
> 
> That should be 5.3.190, since 5.003_19 == 5.003_190.
> 
> Cheers,
> Philip

Yes, you're right.  It also doesn't make much sense to report $] on 
failure if we are actually testing $^V.  It should also be ge not gt.
Fresh patch after sig.

John
--
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4720 Boston Way
Lanham, MD 20706
301-459-3366 x.5010
fax 301-429-5747


--- perl/t/op/magic.t.orig      Thu Aug 23 09:06:48 2001
+++ perl/t/op/magic.t   Thu Aug 23 09:07:36 2001
@@ -182,8 +182,8 @@
     ok 25, unlink($script), $!;
 }

-# $], $^O, $^T
-ok 26, $] >= 5.00319, $];
+# $^V, $^O, $^T
+ok 26, $^V ge 5.3.190, $^V;
 ok 27, $^O;
 ok 28, $^T > 850000000, $^T;

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About