develooper Front page | perl.perl5.porters | Postings from August 2001

Re: [PATCH pp_ctl.c] proposed Windows safe-guard

Thread Previous | Thread Next
From:
Jarkko Hietaniemi
Date:
August 1, 2001 17:01
Subject:
Re: [PATCH pp_ctl.c] proposed Windows safe-guard
Message ID:
20010801190130.Y4053@chaos.wustl.edu
On Mon, Jul 30, 2001 at 05:38:50PM -0700, Doug MacEachern wrote:
> couple of problems with the patch:
> - pkg is malloced but never freed
> - filename -> packagename crunching when Perl already knows the
> packagename elsewhere (and crunching is done even if warnings are off)
> - check happens for require of filenames
> - check happens for runtime require (ie no import happens with 'require Foo')
> 
> i think the right place for this is Perl_utilize (where 'use' becomes
> 'require + import'), which will solve these problems.  there are a few
> tests that fail due to the new warning, but i have not tried fixing those.

Thanks, applied (and fixed those few failing tests).

-- 
$jhi++; # http://www.iki.fi/jhi/
        # There is this special biologist word we use for 'stable'.
        # It is 'dead'. -- Jack Cohen

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About