develooper Front page | perl.perl5.porters | Postings from August 2001

Re: [PATCH 4/4] -Wall cleanups: perlio.c

Thread Previous | Thread Next
From:
Jarkko Hietaniemi
Date:
August 1, 2001 06:52
Subject:
Re: [PATCH 4/4] -Wall cleanups: perlio.c
Message ID:
20010801085152.E4053@chaos.wustl.edu
On Tue, Jul 31, 2001 at 11:16:42PM -0700, Richard Soderberg wrote:
> This is the fourth in a series of patches designed to remove warnings from
> the compilation of Perl on FreeBSD-CURRENT, last updated Jun 19, 2001.
> 
> Applying this patch resolves an unused my_perl warning during compilation;
> apparently dTHX is not necessary to this function.

It is necessary under -Dusethreads.  (I first applied this and *thought*
I tested it, but further testing proved that I was imagining things.)

> All tests passed.
> 
> R.
> 
> --- perlio.c~	Sat Jul 28 23:34:18 2001
> +++ perlio.c	Sat Jul 28 23:34:04 2001
> @@ -407,7 +407,6 @@
>  void
>  PerlIO_list_push(PerlIO_list_t *list,PerlIO_funcs *funcs,SV *arg)
>  {
> - dTHX;
>   PerlIO_pair_t *p;
>   if (list->cur >= list->len)
>    {
> 
> 

-- 
$jhi++; # http://www.iki.fi/jhi/
        # There is this special biologist word we use for 'stable'.
        # It is 'dead'. -- Jack Cohen

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About