develooper Front page | perl.perl5.porters | Postings from August 2001

Re: [PATCH 2/4] -Wall cleanups: mg.c

Thread Previous | Thread Next
From:
Jarkko Hietaniemi
Date:
August 1, 2001 06:35
Subject:
Re: [PATCH 2/4] -Wall cleanups: mg.c
Message ID:
20010801083517.C4053@chaos.wustl.edu
On Tue, Jul 31, 2001 at 11:16:29PM -0700, Richard Soderberg wrote:
> This is the second in a series of patches designed to remove warnings from
> the compilation of Perl on FreeBSD-CURRENT, last updated Jun 19, 2001.
> 
> This patch removes a warning in the compilation of mg.c; there is no third
> argument to setproctitle() - though apparently it accepts it with a warning.
> 
> This removes the third argument from the use of the function, resolving the
> warning.

Hmmm.  The three-arg version was added on purpose a year ago (change
#6483).  I must investigate more, maybe this is something dependent
on the Frisbee version.

> As an interesting note, the setproctitle man page states that it is possible
> that other forms of setproctitle() exist out there, but none have been seen. 
> 
> It is dated December 16, 1995.
> 
> All tests passed.
> 
> R.
> 
> --- mg.c~	Sat Jul 28 22:57:04 2001
> +++ mg.c	Sat Jul 28 22:56:45 2001
> @@ -2089,7 +2089,7 @@
>  	     * but not the "(perl) suffix from the ps(1)
>  	     * output, because that's what ps(1) shows if the
>  	     * argv[] is modified. */
> -	    setproctitle("-%s", s, len + 1);
> +	    setproctitle("-%s", s);
>  #   else	/* old FreeBSDs, NetBSD, OpenBSD, anyBSD */
>  	    /* This doesn't really work if you assume that
>  	     * $0 = 'foobar'; will wipe out 'perl' from the $0
> 
> 

-- 
$jhi++; # http://www.iki.fi/jhi/
        # There is this special biologist word we use for 'stable'.
        # It is 'dead'. -- Jack Cohen

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About