Front page | perl.perl5.porters |
Postings from July 2001
Re: [PATCH] h2ph, etc.
Thread Previous
|
Thread Next
From:
Kurt D. Starsinic
Date:
July 31, 2001 05:37
Subject:
Re: [PATCH] h2ph, etc.
Message ID:
20010731053658.A17262@wolfetech.com
On Sun, Jul 29, 2001 at 01:37:59AM -0700, Michael G Schwern wrote:
> On Wed, Jul 25, 2001 at 11:30:05PM -0700, Kurt D. Starsinic wrote:
> > I expect the Average Platform to get three failures on the test.
>
> You can put them in as todo tests. I'm finishing up the Test::More
> interface to let you do that.
I will.
> > --- /dev/null Thu Jul 26 05:37:06 2001
> > +++ t/lib/h2ph_thorough.t Thu Jul 26 05:35:55 2001
> ...
> > + foreach (@symbols) {
> > + next if %Todo && !defined $Todo{$_};
>
> Wouldn't C<next if !defined $Todo{$_}> work just fine?
That's an artifact from some warning-silencing. I'll rip it out
if I can.
> > + if (!defined $r1) { print OK "ok $i\t# skip $_\n" }
> > + elsif (differ($r1, $r2)) { print "nok $i\t# $_: `$r1' <=> `$pr2 ($pn2)'\n" }
> > + else { print OK "ok $i\t# $_\n" }
>
> ARRR! Kurt, use Test::More, please. I'm putting the finishing
> touches on skip tests.
ARRR yourself. I'll use Test::More as soon as skip and todo tests work.
- Kurt
Thread Previous
|
Thread Next