develooper Front page | perl.perl5.porters | Postings from July 2001

Re: [PATCH] h2ph, etc.

Thread Previous | Thread Next
From:
Michael G Schwern
Date:
July 29, 2001 01:37
Subject:
Re: [PATCH] h2ph, etc.
Message ID:
20010729013759.L2983@blackrider
On Wed, Jul 25, 2001 at 11:30:05PM -0700, Kurt D. Starsinic wrote:
>     I expect the Average Platform to get three failures on the test.

You can put them in as todo tests.  I'm finishing up the Test::More
interface to let you do that.


> --- /dev/null	Thu Jul 26 05:37:06 2001
> +++ t/lib/h2ph_thorough.t	Thu Jul 26 05:35:55 2001
...
> +    foreach (@symbols) {
> +        next if %Todo && !defined $Todo{$_};

Wouldn't C<next if !defined $Todo{$_}> work just fine?


> +        if    (!defined $r1)      { print OK "ok  $i\t# skip $_\n" }
> +        elsif (differ($r1, $r2))  { print "nok $i\t# $_:  `$r1' <=> `$pr2 ($pn2)'\n" }
> +        else                      { print OK "ok  $i\t# $_\n" }

ARRR!  Kurt, use Test::More, please.  I'm putting the finishing
touches on skip tests.


> +print "1..$total\n";

use Test::More qw(no_plan);


-- 

Michael G. Schwern   <schwern@pobox.com>    http://www.pobox.com/~schwern/
Perl6 Quality Assurance     <perl-qa@perl.org>	     Kwalitee Is Job One
Because of DNA recoding, in the future, people can choose their own skin, hair,
and eye color. Human beings will become one race!
	     --Alex Chiu, Immortality Guy

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About