develooper Front page | perl.perl5.porters | Postings from July 2001

[PATCH] Small fix to pp_gmtime

Thread Next
From:
Artur Bergman
Date:
July 10, 2001 10:55
Subject:
[PATCH] Small fix to pp_gmtime
Message ID:
B7710E0B.21C5%artur@contiller.se
No point in extending the stack if we call it in scalar context. All tests
pass.

Artur

--- perl-clone/pp_sys.c    Tue Jul 10 16:15:28 2001
+++ perl/pp_sys.c    Tue Jul 10 18:47:33 2001
@@ -4323,10 +4323,10 @@
     else
         tmbuf = gmtime(&when);
 
-    EXTEND(SP, 9);
-    EXTEND_MORTAL(9);
     if (GIMME != G_ARRAY) {
         SV *tsv;
+        EXTEND(SP, 1);
+        EXTEND_MORTAL(1);
         if (!tmbuf)
             RETPUSHUNDEF;
         tsv = Perl_newSVpvf(aTHX_ "%s %s %2d %02d:%02d:%02d %d",
@@ -4340,7 +4340,9 @@
         PUSHs(sv_2mortal(tsv));
     }
     else if (tmbuf) {
-        PUSHs(sv_2mortal(newSViv(tmbuf->tm_sec)));
+        EXTEND(SP, 9);
+        EXTEND_MORTAL(9);
+        PUSHs(sv_2mortal(newSViv(tmbuf->tm_sec)));
         PUSHs(sv_2mortal(newSViv(tmbuf->tm_min)));
         PUSHs(sv_2mortal(newSViv(tmbuf->tm_hour)));
         PUSHs(sv_2mortal(newSViv(tmbuf->tm_mday)));


Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About