Front page | perl.perl5.porters |
Postings from July 2001
Re: [PATCH @11016] Fixes compile errors in four files
Thread Previous
|
Thread Next
From:
Philip Newton
Date:
July 3, 2001 08:03
Subject:
Re: [PATCH @11016] Fixes compile errors in four files
Message ID:
3B41FAE6.29564.660E117@localhost
On 29 Jun 2001, at 3:35, Richard Soderberg wrote:
> Semicolons everywhere, and now it works, I think.
>
> This patch fixes compile errors in 11016 - semicolons are a line
> terminator, which was breaking things.
>
> --- pp_hot.c.orig Fri Jun 29 03:31:15 2001
> +++ pp_hot.c Fri Jun 29 03:31:25 2001
> @@ -2651,7 +2651,7 @@
> }
> DEBUG_S(if (CvDEPTH(cv) != 0)
> PerlIO_printf(Perl_debug_log, "depth %ld != 0\n",
> - CvDEPTH(cv)););
> + CvDEPTH(cv)));;
> SAVEDESTRUCTOR_X(unset_cvowner, (void*) cv);
> }
> }
> @@ -3116,7 +3116,7 @@
> MUTEX_LOCK(CvMUTEXP(cv));
> DEBUG_S(if (CvDEPTH(cv) != 0)
> PerlIO_printf(Perl_debug_log, "depth %ld != 0\n",
> - CvDEPTH(cv)););
> + CvDEPTH(cv)));;
> assert(thr == CvOWNER(cv));
> CvOWNER(cv) = 0;
> MUTEX_UNLOCK(CvMUTEXP(cv));
Do you really need that many semicolons? All the other places seem
to do fine with just one. This patch kills the extra semicolon.
--- pp_hot.c.orig Fri Jun 29 14:23:23 2001
+++ pp_hot.c Tue Jul 3 14:15:27 2001
@@ -2651,7 +2651,7 @@
}
DEBUG_S(if (CvDEPTH(cv) != 0)
PerlIO_printf(Perl_debug_log, "depth %ld != 0\n",
- CvDEPTH(cv)));;
+ CvDEPTH(cv)));
SAVEDESTRUCTOR_X(unset_cvowner, (void*) cv);
}
}
@@ -3116,7 +3116,7 @@
MUTEX_LOCK(CvMUTEXP(cv));
DEBUG_S(if (CvDEPTH(cv) != 0)
PerlIO_printf(Perl_debug_log, "depth %ld != 0\n",
- CvDEPTH(cv)));;
+ CvDEPTH(cv)));
assert(thr == CvOWNER(cv));
CvOWNER(cv) = 0;
MUTEX_UNLOCK(CvMUTEXP(cv));
End of patch.
Cheers,
Philip
--
Philip Newton <pnewton@gmx.de>
Thread Previous
|
Thread Next