develooper Front page | perl.perl5.porters | Postings from July 2001

RE: gv.c is not acceptable for Borland now

Thread Previous | Thread Next
From:
vkonovalov
Date:
July 2, 2001 04:10
Subject:
RE: gv.c is not acceptable for Borland now
Message ID:
E3FB32585BF1D411B9E900805FF51A08074B75@RU0022EXCH001U
> > I've discovered that Borland C++ does not accepts a 
> construct in gv.c (it explains that '#' is unexpected here, 
> i.e. some preprocessor failure)
> > 
> > I've marked them as //vv in patch in order to build perl, 
> but real patch must be smarter than this.
> 
> Why use C++ comment style? I'd expect almost any other 
> non-C++ ANSI compiler
> to choak on this. Please use /*...*/

No-no-no! Please understand, that I was not inclined to introduce those lines into perl source code!
And I don't want for Borland worms to crawl in the source tree!
I noticed several times to not accept that patch, and it was included only for evidence of what is going on.

> > someone who wrote these lines, please change them in a more 
> clever for other compilers way.
> > 
> > diff -u -r perl@11059-orig/gv.c perl@11059/gv.c
> > --- perl@11059-orig/gv.c	Sun Jul  1 01:21:34 2001
> > +++ perl@11059/gv.c	Mon Jul  2 10:13:14 2001
> > @@ -1365,9 +1365,9 @@
> >  #endif
> >    if (!(AMGf_noleft & flags) && SvAMAGIC(left)
> >        && (mg = mg_find((SV*)(
> > -#ifdef DEGUGGING
> > +//vv #ifdef DEGUGGING

Best wishes,
<!ENTITY Vadim REALLIFE "Vadim V.Konovalov, St.Petersburg, Russia">
&Vadim;

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About