Re: [patch] perl_clone+CvFILE

Doug MacEachern wrote:
> --- sv.c	2001/06/21 21:23:57	1.1.1.53
> +++ sv.c	2001/06/25 22:16:23
> @@ -9004,6 +9004,7 @@
>  	else
>  	    CvOUTSIDE(dstr)= cv_dup(CvOUTSIDE(sstr), param);
>  	CvFLAGS(dstr)= CvFLAGS(sstr);
> +	CvFILE(dstr) = CvXSUB(sstr) ? CvFILE(sstr) : SAVEPV(CvFILE(sstr));
>  	break;
>      default:
>  	Perl_croak(aTHX_ "Bizarre SvTYPE [%d]", SvTYPE(sstr));

I fear that is a memory leak under non-ithreads builds.
Should it be something like:
#ifdef USE_ITHREADS
    CvFILE(dstr) = CvXSUB(sstr) ? CvFILE(sstr) : SAVEPV(CvFILE(sstr));
#else
    CvFILE(dstr) = CvFILE(sstr);
#endif

?
 .robin.

• [patch] perl_clone+CvFILE by Doug MacEachern
• Re: [patch] perl_clone+CvFILE by Robin Houston
• Re: [patch] perl_clone+CvFILE by Doug MacEachern
• Re: [patch] perl_clone+CvFILE by Jarkko Hietaniemi