Front page | perl.perl5.porters |
Postings from April 2001
In <20010429153522.A25462@math.ohio-state.edu>, Ilya Zakharevich writes: :> --- thrdvar.h.old Tue Jan 30 18:14:40 2001 :> +++ thrdvar.h Sun Apr 29 16:18:07 2001 :> @@ -183,7 +183,6 @@ :> PERLVAR(Tregendp, I32 *) /* Ditto for endp. */ :> PERLVAR(Treglastparen, U32 *) /* Similarly for lastparen. */ :> PERLVAR(Tregtill, char *) /* How far we are required to go. */ :> -PERLVAR(Tregprev, char) /* char before regbol, \n if none */ :> PERLVAR(Treg_start_tmp, char **) /* from regexec.c */ :> PERLVAR(Treg_start_tmpl,U32) /* from regexec.c */ :> PERLVAR(Tregdata, struct reg_data *) : :This is not possible for binary backward-compatibility reasons. The :old entries should remain. Is that relevant for bleadperl? I thought binary compatibility was already broken between 5.6 and 5.8. If not, it should probably be renamed to 'unused' or somesuch if the rest of the patch is accepted. :> - if (s == startpos) :> + if (s == PL_bostr) : :Why? This would slow things down. Because it is not right otherwise: startpos is the position in the string at which we are starting to match, and we need to check against the actual previous character if that isn't the beginning of the whole string. HugoThread Previous | Thread Next