Front page | perl.perl5.porters |
Postings from March 2001
On Mon, 26 Mar 2001 18:20:24 +0200, Thorsten Ziege wrote:
[about an issue with the Borland compiler]
>I could remove all except one error in op/misc. Here it comes:
>
>###################################################################
>op/misc.............ok 54/55PROG:
>BEGIN {
> $| = 1;
> $SIG{__WARN__}
>EXPECTED:
>
>GOT:
>Missing right curly or square bracket at - line 3, at end of line
>syntax error at - line 3, at EOF
>Execution of - aborted due to compilation errors.
>op/misc.............FAILED test 55
> Failed 1/55 tests, 98.18% okay
>###################################################################
This is due to a thinko in a workaround that was in 5.6.0 for quirkiness
in the Borland compiler's CRT. The problem only shows up when you extract
the files such that misc.t has CRLF terminations, which explains why only
some people were seeing it.
Here's a fix.
Sarathy
gsar@ActiveState.com
-----------------------------------8<-----------------------------------
Change 9493 by gsar@moonru on 2001/03/31 20:18:05
fix a broken workaround for Borland compiler in change#4739
(caused weird "short reads" on DATA, which caused op/misc.t to fail)
Affected files ...
... //depot/maint-5.6/perl/toke.c#59 edit
Differences ...
==== //depot/maint-5.6/perl/toke.c#59 (text) ====
Index: perl/toke.c
--- perl/toke.c.~1~ Sat Mar 31 12:46:14 2001
+++ perl/toke.c Sat Mar 31 12:46:14 2001
@@ -4125,7 +4125,7 @@
if (PerlLIO_setmode(PerlIO_fileno(PL_rsfp), O_TEXT) != -1) {
#if defined(__BORLANDC__)
/* XXX see note in do_binmode() */
- ((FILE*)PL_rsfp)->flags |= _F_BIN;
+ ((FILE*)PL_rsfp)->flags &= ~_F_BIN;
#endif
if (loc > 0)
PerlIO_seek(PL_rsfp, loc, 0);
End of Patch.