Front page | perl.perl5.porters |
Postings from March 2001
Re: pods patched
Thread Previous
|
Thread Next
From:
Michael Stevens
Date:
March 18, 2001 09:42
Subject:
Re: pods patched
Message ID:
20010318174237.A8110@firedrake.org
On Sat, Mar 17, 2001 at 02:55:23PM -0500, Ilya Zakharevich wrote:
> Even less: one byte changes:
>
> This module is very unusual as overloaded modules go: it does not
> -provide any usual overloaded operators, instead it provides the L<Last
> -Resort> operator C<nomethod>. In this example the corresponding
> +provide any usual overloaded operators, instead it provides the
> +L<Last Resort> operator C<nomethod>. In this example the corresponding
> subroutine returns an object which encapsulates operations done over
>
> Note that the only change is a removal of \n inside L<>. As if the
> POD parsers do not normalize whitespace inside L<> and X<>.
>
> Of course, many converters have bugs (like pod2man which breaks in the
> presense of newlines inside X<>), but we should not base POD on lame
> converters. [IIRC, pod2html wouldn't grok even L<function C<bar>>, not
> taking about C<func(I<ARGLIST>)>.]
Ok, so if you really feel we shouldn't warn about it:
diff -urN perl-current.orig/lib/Pod/Checker.pm perl-current/lib/Pod/Checker.pm
--- perl-current.orig/lib/Pod/Checker.pm Sun Mar 18 17:21:19 2001
+++ perl-current/lib/Pod/Checker.pm Sun Mar 18 17:31:09 2001
@@ -287,11 +287,6 @@
=over 4
-=item * collapsing newlines to blanks
-
-A hyperlink LE<lt>...E<gt> spans more than one line. This may indicate
-and error.
-
=item * ignoring leading/trailing whitespace in link
There is whitespace at the beginning or the end of the contents of
diff -urN perl-current.orig/lib/Pod/ParseUtils.pm perl-current/lib/Pod/ParseUtils.pm
--- perl-current.orig/lib/Pod/ParseUtils.pm Sun Mar 18 17:21:19 2001
+++ perl-current/lib/Pod/ParseUtils.pm Sun Mar 18 17:30:59 2001
@@ -289,9 +289,8 @@
$self->{_warnings} = [];
# collapse newlines with whitespace
- if(s/\s*\n+\s*/ /g) {
- $self->warning("collapsing newlines to blanks");
- }
+ s/\s*\n+\s*/ /g;
+
# strip leading/trailing whitespace
if(s/^[\s\n]+//) {
$self->warning("ignoring leading whitespace in link");
Thread Previous
|
Thread Next