develooper Front page | perl.perl5.porters | Postings from March 2001

Re: my purify runs with 5.6.1-to-be

Thread Previous | Thread Next
From:
Jarkko Hietaniemi
Date:
March 16, 2001 13:59
Subject:
Re: my purify runs with 5.6.1-to-be
Message ID:
20010316155831.N10215@chaos.wustl.edu
> What I found is that in clear_pmop PmopSTASH(cPMOPo) is corrupt, I
> guess because it was already cleared. HvPMROOT(pmstash) returns
> garbage and we get the coredump.
> 
> Changing this line in Sarathy's patch from
> 
>  clear_pmop:
> +	{
> +	    HV *pmstash = PmopSTASH(cPMOPo);
> +	    if (pmstash) {
> 
> to
> 
> +	    if (pmstash && SvREFCNT(pmstash)) {
> 
> stops the coredumps but I'm not sure if SvREFCNT(pmstash) is to be trusted
> if pmstash was already cleared.

This change makes my core dumps go away, too.

-- 
$jhi++; # http://www.iki.fi/jhi/
        # There is this special biologist word we use for 'stable'.
        # It is 'dead'. -- Jack Cohen

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About