develooper Front page | perl.perl5.porters | Postings from January 2001

[PATCH] Re: [ID 20001222.001] Not OK: perl v5.7.0 +DEVEL8221 on i686-linux 2.2.18

Thread Previous
From:
Nicholas Clark
Date:
January 30, 2001 10:52
Subject:
[PATCH] Re: [ID 20001222.001] Not OK: perl v5.7.0 +DEVEL8221 on i686-linux 2.2.18
Message ID:
20010130185201.P76607@plum.flirble.org
On Fri, Dec 22, 2000 at 08:19:22PM +0000, Nicholas Clark wrote:
> On Fri, Dec 22, 2000 at 11:32:29AM +0000, Michael Stevens wrote:
> > A test in glob-basic.t fails:
> > 
> > michaels@icicle:~/perl-current> ./perl -Ilib t/lib/glob-basic.t 
> > 1..9
> > ok 1
> > ok 2
> > ok 3
> > ok 4
> > ok 5
> > ok 6
> > ok 7
> > not ok 8
> > ok 9
> 
> What does @a contain then?
> 
> unless (@a == 3
>         and $a[0] eq ($^O eq 'VMS'? 'test.' : 'TEST')
>         and $a[1] eq 'a'
>         and $a[2] eq 'b')
> {
>     print "not ";
> }
> print "ok 8\n";

Could I suggest the following:

--- t/lib/glob-basic.t.orig	Sun Dec 31 16:12:16 2000
+++ t/lib/glob-basic.t	Tue Jan 30 18:44:19 2001
@@ -106,9 +106,10 @@
         and $a[1] eq 'a'
         and $a[2] eq 'b')
 {
-    print "not ";
+    print "not ok 8 # @a\n";
+} else {
+    print "ok 8\n";
 }
-print "ok 8\n";
 
 # "~" should expand to $ENV{HOME}
 $ENV{HOME} = "sweet home";



I've been editing things, and it's more helpful to know that a failure
is because of this:

./perl lib/glob-basic.t 
1..9
ok 1
ok 2
ok 3
ok 4
ok 5
ok 6
ok 7
not ok 8 # TEST TEST.orig TEST~ a b
ok 9

This may or may not relate to the original bug.

Nicholas Clark

Thread Previous


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About