Re: [PATCH 5.7.0] overload int()

On Thu, 25 Jan 2001, Steve Fink wrote:

> Ilya Zakharevich wrote:
> > 
> > --- ./perl.h~   Tue Jan 16 20:44:51 2001
> > +++ ./perl.h    Wed Jan 24 15:21:04 2001
> > @@ -3064,7 +3064,8 @@ enum {
> >    to_sv_amg,   to_av_amg,
> >    to_hv_amg,   to_gv_amg,
> >    to_cv_amg,   iter_amg,
> > -  DESTROY_amg, max_amg_code
> > +  int_amg,     DESTROY_amg,
> > +  max_amg_code
> >    /* Do not leave a trailing comma here.  C9X allows it, C89 doesn't. */
> 
> This is not relevant to your patch, but perl doesn't appear to be
> consistent with the above comment
> 
> >  };
> > 
> > @@ -3110,7 +3111,7 @@ EXTCONST char * PL_AMG_names[NofAMmeth]
> >    "(${}",      "(@{}",
> >    "(%{}",      "(*{}",
> >    "(&{}",      "(<>",
> > -  "DESTROY",
> > +  "(int",      "DESTROY",
> >  };
> >  #else
> >  EXTCONST char * PL_AMG_names[NofAMmeth];
> 
> as can be seen here.

The first is an enum definition, the second is an array initialization.
C89 doesn't allow trailing commas on enum definitions, but it does allow
them on aggregate initializers.

Tony

• [PATCH 5.7.0] overload int() by Ilya Zakharevich
• Re: [PATCH 5.7.0] overload int() by Jarkko Hietaniemi
• Re: [PATCH 5.7.0] overload int() by Steve Fink
• Re: [PATCH 5.7.0] overload int() by Tony Cook
• Re: [PATCH 5.7.0] overload int() by Jarkko Hietaniemi