develooper Front page | perl.perl5.porters | Postings from January 2001

Re: [PATCH 1.14] (was Re: Unifying 'skip' and 'todo' testoutput)

Thread Previous
Tim Jenness
January 18, 2001 01:07
Re: [PATCH 1.14] (was Re: Unifying 'skip' and 'todo' testoutput)
Message ID:
On Thu, 18 Jan 2001, Michael G Schwern wrote:

> On Wed, Jan 17, 2001 at 06:37:33PM -1000, Tim Jenness wrote:
> The fact that this patch blows a regression test worries me.  Does
> skip() have any valid utility if its first argument doesn't begin with
> 'skip'?  Is skip('hop') useful (before the patch)?

As far as I could tell a well back when I was looking at this it seemed
that if the skip reason does not start with the word "skip" then
Test::Harness does not treat it as a skipped test. When I first came
across this it did confuse me a little since I expected the skip()
function to deal with the behaviour of Test::Harness not force you to deal
with it.

Your patch to handle the case of no "skip" in the reason looks good to me.

PS You should try dealing with ok() output that comes from multiple BEGIN
and END blocks if you are worried about ordering (the ftmp tests do this).

PPS I usually add a information message just before the ok() rather than
as part of the ok so I am with Andreas on that issue.

Tim Jenness
JCMT software engineer/Support scientist

Thread Previous Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at | Group listing | About