develooper Front page | perl.perl5.porters | Postings from January 2001

Re: [PATCH: perl@8429] Win32 Makefile fixes

Thread Previous | Thread Next
From:
Jarkko Hietaniemi
Date:
January 16, 2001 10:45
Subject:
Re: [PATCH: perl@8429] Win32 Makefile fixes
Message ID:
20010116124451.M21189@chaos.wustl.edu
On Tue, Jan 16, 2001 at 09:36:53PM +0300, Konovalov, Vadim wrote:
> > > The enclosed patch contains the following changes to the 
> > Win32 Makefile
> > > 
> > > 1) Changed default compiler options to release instead of debug.
> > > 2) Changed default compile flags to generate binary 
> > compatible code with
> > > existiting Win32 module repositories.
> > 
> > Thanks, applied.  (patch -l needed since my patch didn't like the
> > the extra whitespace)
> 
> I feel uncomfortable with that patch because:
>  1. I think that one who patches win32/Makefile should also consider
> patching win32/makefile.mk, at least for symmetry; because it also supports
> MSVC++;

This has been discussed (in the form of having a common source file
from which both the makefiles would be generated), so far no
implementations have shown up.

>  2. I think that logic that was thrown away by deleting several lines in
> win32/Makefile should still remain in there and updated in slightly
> different manner...

Patches welcome, as always.

> I vote for more consistent update in those files.
> 
> <!ENTITY Vadim REALLIFE "Vadim V.Konovalov, St.Petersburg, Russia">
> &Vadim;

-- 
$jhi++; # http://www.iki.fi/jhi/
        # There is this special biologist word we use for 'stable'.
        # It is 'dead'. -- Jack Cohen

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About