develooper Front page | perl.perl5.porters | Postings from January 2001

RE: [PATCH: perl@8429] Win32 Makefile fixes

Thread Previous | Thread Next
From:
Konovalov, Vadim
Date:
January 16, 2001 10:36
Subject:
RE: [PATCH: perl@8429] Win32 Makefile fixes
Message ID:
402099F49BEED211999700805FC7359F964CEF@ru0028exch01.spb.lucent.com
> > The enclosed patch contains the following changes to the 
> Win32 Makefile
> > 
> > 1) Changed default compiler options to release instead of debug.
> > 2) Changed default compile flags to generate binary 
> compatible code with
> > existiting Win32 module repositories.
> 
> Thanks, applied.  (patch -l needed since my patch didn't like the
> the extra whitespace)

I feel uncomfortable with that patch because:
 1. I think that one who patches win32/Makefile should also consider
patching win32/makefile.mk, at least for symmetry; because it also supports
MSVC++;
 2. I think that logic that was thrown away by deleting several lines in
win32/Makefile should still remain in there and updated in slightly
different manner...

I vote for more consistent update in those files.

<!ENTITY Vadim REALLIFE "Vadim V.Konovalov, St.Petersburg, Russia">
&Vadim;

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About