develooper Front page | perl.perl5.porters | Postings from January 2001

Re: [PATCH @8404] Consolidated lvalue sub changes

Thread Previous | Thread Next
From:
Jarkko Hietaniemi
Date:
January 12, 2001 08:12
Subject:
Re: [PATCH @8404] Consolidated lvalue sub changes
Message ID:
20010112101152.K12002@chaos.wustl.edu
On Wed, Jan 10, 2001 at 09:36:51PM -0800, Stephen McCamant wrote:
> Whew. The following patch against perl-current subsumes Simon's two
> recent lvalue subroutine patch (array and hash elements, and whole
> arrays and hashes), plus the everything from the working snapshot I
> posted earlier, plus croaks to keep returning an array to scalar
> lvalue context from segfaulting, plus a change to set attributes
> earlier (but keeping the later setting too, for the
> backwards-compatibility police), plus changes to enable lvalue returns 
> of array and hash slices and lvalue calls to substr(), pos() and
> vec(), and tests.
> 
> I didn't feel like there was a consensus about stronger compile-time
> checking of lvalue returns, so I just followed my own tastes and left
> the code in the strict-checking mode. The tests were updated to match
> the new behavior.
> 
> This code sets flags for the arguments to return, but since the
> version I'm patching against doesn't do leavesublv-ish things in
> pp_return, lvalue return()s don't really work, and aren't tested.
> 
>  -- Stephen McC
> 
> --- perl-current/opcode.pl	Sun Dec 31 09:27:14 2000
> +++ perl+lval2/opcode.pl	Wed Jan 10 20:24:56 2001

Thanks, applied.  Though Tim's concern about the perldiag message
should still be addressed.

-- 
$jhi++; # http://www.iki.fi/jhi/
        # There is this special biologist word we use for 'stable'.
        # It is 'dead'. -- Jack Cohen

Thread Previous | Thread Next


nntp.perl.org: Perl Programming lists via nntp and http.
Comments to Ask Bjørn Hansen at ask@perl.org | Group listing | About