On Fri, Jan 05, 2001 at 07:40:28AM -0600, Jarkko Hietaniemi wrote: > > > Yes, it seems that the code once again assumed ASCII encoding, the raw > > > & 0x80 tells us that. I actually already had changed that to be > > > abstracted behind a macro, UTF8_IS_CONTINUED(). Next we'll need to > > > define these macros in EBCDIC correctly (mapping to ASCII and back). > > > Simon Cozens already had some patches to this effect a few weeks back, > > > I'll go dig. > > > > > Yes I'm working on an EBCDIC environment. > > In any case function uv_to_utf8 adds a NULL character at the end of the > > destination buffer and as it is handling the string backwards, last > > character will be overwritten. > > So I thing that my patch should be applied. > > Yes, that's true. My only gripe about the patch itself as such is that it calls strncpy(). strncpy() is not used in the Perl core code, there's actually only one spot, in utf8.c. > > > > > would fail for me? > > > > > > > > > > BTW, the patch arrived here line-wrapped. I fixed that manually and > > > > > applied with -l. Maybe you should resubmit as an attachment and > > > > > include your perl -V. -- $jhi++; # http://www.iki.fi/jhi/ # There is this special biologist word we use for 'stable'. # It is 'dead'. -- Jack CohenThread Previous